From: Jens Axboe <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: io_uring Mailing List <[email protected]>
Subject: Re: [PATCH liburing v2 0/2] Fix endianess issue and add srand()
Date: Mon, 27 Sep 2021 07:45:48 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 9/27/21 7:40 AM, Ammar Faizi wrote:
> On Mon, Sep 27, 2021 at 8:28 PM Jens Axboe <[email protected]> wrote:
>>
>> On 9/26/21 10:37 PM, Ammar Faizi wrote:
>>> The use of `rand()` should be accompanied by `srand()`.
>>
>> The idiomatic way that I usually do it for these tests is:
>>
>> srand(getpid());
>>
>> Shouldn't really matter, but we may as well keep it consistent.
>
> v2: Use getpid() for the random seed.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-09-27 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 4:37 [PATCH liburing 0/2] Fix endianess issue and add srand() Ammar Faizi
2021-09-27 4:37 ` [PATCH liburing 1/2] test: Fix endianess issue on `bind()` and `connect()` Ammar Faizi
2021-09-27 4:37 ` [PATCH liburing 2/2] test/accept-link: Add `srand()` for better randomness Ammar Faizi
2021-09-27 13:28 ` Jens Axboe
2021-09-27 13:40 ` [PATCH liburing v2 0/2] Fix endianess issue and add srand() Ammar Faizi
2021-09-27 13:40 ` [PATCH liburing v2 1/2] test: Fix endianess issue on `bind()` and `connect()` Ammar Faizi
2021-09-27 13:40 ` [PATCH liburing v2 2/2] test/accept-link: Add `srand()` for better randomness Ammar Faizi
2021-09-27 13:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox