public inbox for [email protected]
 help / color / mirror / Atom feed
From: Hao Xu <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], Pavel Begunkov <[email protected]>,
	Joseph Qi <[email protected]>
Subject: Re: [PATCH 6/8] io_uring: add nr_ctx to record the number of ctx in a task
Date: Thu, 28 Oct 2021 14:27:01 +0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

在 2021/10/27 下午10:02, Hao Xu 写道:
> This is used in the next patch for task_work batch optimization.
> 
> Signed-off-by: Hao Xu <[email protected]>
haven't done the sqpoll part. nr_ctx works for
non-sqpoll mode for now.
> ---
>   fs/io_uring.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index db5d9189df3a..7c6d90d693b8 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -470,6 +470,7 @@ struct io_uring_task {
>   	struct io_wq_work_list	prior_task_list;
>   	struct callback_head	task_work;
>   	bool			task_running;
> +	unsigned int		nr_ctx;
>   };
>   
>   /*
> @@ -9655,6 +9656,9 @@ static int __io_uring_add_tctx_node(struct io_ring_ctx *ctx)
>   		mutex_lock(&ctx->uring_lock);
>   		list_add(&node->ctx_node, &ctx->tctx_list);
>   		mutex_unlock(&ctx->uring_lock);
> +		spin_lock_irq(&tctx->task_lock);
> +		tctx->nr_ctx++;
> +		spin_unlock_irq(&tctx->task_lock);
>   	}
>   	tctx->last = ctx;
>   	return 0;
> @@ -9692,6 +9696,9 @@ static __cold void io_uring_del_tctx_node(unsigned long index)
>   	mutex_lock(&node->ctx->uring_lock);
>   	list_del(&node->ctx_node);
>   	mutex_unlock(&node->ctx->uring_lock);
> +	spin_lock_irq(&tctx->task_lock);
> +	tctx->nr_ctx--;
> +	spin_unlock_irq(&tctx->task_lock);
>   
>   	if (tctx->last == node->ctx)
>   		tctx->last = NULL;
> 


  reply	other threads:[~2021-10-28  6:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 14:02 [PATCH for-5.16 v3 0/8] task work optimization Hao Xu
2021-10-27 14:02 ` [PATCH 1/8] io-wq: add helper to merge two wq_lists Hao Xu
2021-10-27 14:02 ` [PATCH 2/8] io_uring: add a priority tw list for irq completion work Hao Xu
2021-10-27 14:02 ` [PATCH 3/8] io_uring: add helper for task work execution code Hao Xu
2021-10-27 14:02 ` [PATCH 4/8] io_uring: split io_req_complete_post() and add a helper Hao Xu
2021-10-27 14:02 ` [PATCH 5/8] io_uring: move up io_put_kbuf() and io_put_rw_kbuf() Hao Xu
2021-10-27 14:02 ` [PATCH 6/8] io_uring: add nr_ctx to record the number of ctx in a task Hao Xu
2021-10-28  6:27   ` Hao Xu [this message]
2021-10-27 14:02 ` [PATCH 7/8] io_uring: batch completion in prior_task_list Hao Xu
2021-10-27 14:02 ` [PATCH 8/8] io_uring: add limited number of TWs to priority task list Hao Xu
2021-10-27 16:39 ` [PATCH for-5.16 v3 0/8] task work optimization Hao Xu
2021-10-27 18:15 ` Pavel Begunkov
2021-10-28  6:07   ` Hao Xu
2021-10-28 11:46     ` Hao Xu
2021-10-28 19:08       ` Pavel Begunkov
2021-10-29  6:18         ` Hao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b168dde-6c62-cbac-158b-a9b824222639@linux.alibaba.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox