* [PATCH 1/1] io_uring/zcrx: increment fallback loop src offset
@ 2025-10-08 12:39 Pavel Begunkov
2025-10-08 17:32 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2025-10-08 12:39 UTC (permalink / raw)
To: io-uring; +Cc: asml.silence, axboe, netdev
Don't forget to adjust the source offset in io_copy_page(), otherwise
it'll be copying into the same location in some cases for highmem
setups.
Fixes: e67645bb7f3f4 ("io_uring/zcrx: prepare fallback for larger pages")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
io_uring/zcrx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c
index eb023c4bc0ff..0a43acbdef98 100644
--- a/io_uring/zcrx.c
+++ b/io_uring/zcrx.c
@@ -1079,6 +1079,7 @@ static ssize_t io_copy_page(struct io_copy_cache *cc, struct page *src_page,
cc->size -= n;
cc->offset += n;
+ src_offset += n;
len -= n;
copied += n;
}
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] io_uring/zcrx: increment fallback loop src offset
2025-10-08 12:39 [PATCH 1/1] io_uring/zcrx: increment fallback loop src offset Pavel Begunkov
@ 2025-10-08 17:32 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2025-10-08 17:32 UTC (permalink / raw)
To: io-uring, Pavel Begunkov; +Cc: netdev
On Wed, 08 Oct 2025 13:39:01 +0100, Pavel Begunkov wrote:
> Don't forget to adjust the source offset in io_copy_page(), otherwise
> it'll be copying into the same location in some cases for highmem
> setups.
>
>
Applied, thanks!
[1/1] io_uring/zcrx: increment fallback loop src offset
commit: e9a9dcb4ccb32446165800a9d83058e95c4833d2
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-08 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-08 12:39 [PATCH 1/1] io_uring/zcrx: increment fallback loop src offset Pavel Begunkov
2025-10-08 17:32 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox