From: Jens Axboe <[email protected]>
To: Xiaoguang Wang <[email protected]>,
[email protected]
Cc: [email protected]
Subject: Re: [FIO PATCH] engines/io_uring: delete fio_option_is_set() calls when submitting sqes
Date: Thu, 12 Mar 2020 06:59:59 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/12/20 5:16 AM, Xiaoguang Wang wrote:
> The fio_option_is_set() call in fio_ioring_prep() is time-consuming,
> which will reduce sqe's submit rate drastically. To fix this issue,
> add two new variables to record whether ioprio_class or ioprio_set
> is set. I use a simple fio job to evaluate the performance:
> fio -name=fiotest -filename=/dev/nvme0n1 -iodepth=4 -thread -rw=read
> -ioengine=io_uring -hipri=0 -sqthread_poll=0 -direct=1 -bs=4k -size=10G
> -numjobs=1 -time_based -runtime=120
>
> Before this patch:
> READ: bw=969MiB/s (1016MB/s), 969MiB/s-969MiB/s (1016MB/s-1016MB/s),
> io=114GiB (122GB), run=120001-120001msec
>
> With this patch:
> READ: bw=1259MiB/s (1320MB/s), 1259MiB/s-1259MiB/s (1320MB/s-1320MB/s),
> io=148GiB (158GB), run=120001-120001msec
Thanks, in hindsight that was pretty dumb!
--
Jens Axboe
prev parent reply other threads:[~2020-03-12 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 11:16 [FIO PATCH] engines/io_uring: delete fio_option_is_set() calls when submitting sqes Xiaoguang Wang
2020-03-12 12:59 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox