public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: [PATCH 2/8] io_uring: reliably cancel linked timeouts
Date: Thu,  4 Mar 2021 13:59:25 +0000	[thread overview]
Message-ID: <1b512b100d137b14826b956f4766b7d6afaced15.1614866085.git.asml.silence@gmail.com> (raw)
In-Reply-To: <[email protected]>

Linked timeouts are fired asynchronously (i.e. soft-irq), and use
generic cancellation paths to do its stuff, including poking into io-wq.
The problem is that it's racy to access tctx->io_wq, as
io_uring_task_cancel() and others may be happening at this exact moment.
Mark linked timeouts with REQ_F_INLIFGHT for now, making sure there are
no timeouts before io-wq destraction.

Signed-off-by: Pavel Begunkov <[email protected]>
---
 fs/io_uring.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index c340d7ba40a2..f82f46c604d7 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -5500,6 +5500,7 @@ static int io_timeout_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe,
 
 	data->mode = io_translate_timeout_mode(flags);
 	hrtimer_init(&data->timer, CLOCK_MONOTONIC, data->mode);
+	io_req_track_inflight(req);
 	return 0;
 }
 
-- 
2.24.0


  parent reply	other threads:[~2021-03-04 14:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04 13:59 [PATCH 5.12 0/8] remove task file notes Pavel Begunkov
2021-03-04 13:59 ` [PATCH 1/8] io_uring: cancel-match based on flags Pavel Begunkov
2021-03-04 13:59 ` Pavel Begunkov [this message]
2021-03-04 13:59 ` [PATCH 3/8] io_uring: make del_task_file more forgiving Pavel Begunkov
2021-03-04 13:59 ` [PATCH 4/8] io_uring: introduce ctx to tctx back map Pavel Begunkov
2021-03-04 13:59 ` [PATCH 5/8] io_uring: do ctx initiated file note removal Pavel Begunkov
2021-03-04 13:59 ` [PATCH 6/8] io_uring: don't take task ring-file notes Pavel Begunkov
2021-03-04 13:59 ` [PATCH 7/8] io_uring: index io_uring->xa by ctx not file Pavel Begunkov
2021-03-04 13:59 ` [PATCH 8/8] io_uring: warn when ring exit takes too long Pavel Begunkov
2021-03-05  4:25   ` Jens Axboe
2021-03-05 11:15     ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b512b100d137b14826b956f4766b7d6afaced15.1614866085.git.asml.silence@gmail.com \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox