From: Jens Axboe <[email protected]>
To: io-uring <[email protected]>
Subject: [PATCH] io_uring: pick up link work on submit reference drop
Date: Tue, 25 Feb 2020 13:27:19 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
If work completes inline, then we should pick up a dependent link item
in __io_queue_sqe() as well. If we don't do so, we're forced to go async
with that item, which is suboptimal.
Signed-off-by: Jens Axboe <[email protected]>
---
diff --git a/fs/io_uring.c b/fs/io_uring.c
index ffd9bfa84d86..160cf1b0f478 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -4531,8 +4531,15 @@ static void io_wq_submit_work(struct io_wq_work **workptr)
} while (1);
}
- /* drop submission reference */
- io_put_req(req);
+ /*
+ * Drop submission reference. In case the handler already dropped the
+ * completion reference, then it didn't pick up any potential link
+ * work. If 'nxt' isn't set, try and do that here.
+ */
+ if (nxt)
+ io_put_req(req);
+ else
+ io_put_req_find_next(req, &nxt);
if (ret) {
req_set_fail_links(req);
--
Jens Axboe
next reply other threads:[~2020-02-25 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 20:27 Jens Axboe [this message]
2020-02-25 21:22 ` [PATCH] io_uring: pick up link work on submit reference drop Pavel Begunkov
2020-02-25 21:25 ` Jens Axboe
2020-02-25 21:41 ` Jens Axboe
2020-02-25 22:18 ` Jens Axboe
2020-02-26 8:33 ` Pavel Begunkov
2020-02-26 9:46 ` Pavel Begunkov
2020-02-26 14:04 ` Jens Axboe
2020-02-25 21:45 ` Pavel Begunkov
2020-02-25 21:52 ` Pavel Begunkov
2020-02-25 22:24 ` Jens Axboe
2020-02-26 6:32 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox