From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C07FBC001B0 for ; Thu, 13 Jul 2023 04:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233783AbjGMESV (ORCPT ); Thu, 13 Jul 2023 00:18:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233653AbjGMESN (ORCPT ); Thu, 13 Jul 2023 00:18:13 -0400 X-Greylist: delayed 90110 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 12 Jul 2023 21:18:12 PDT Received: from out-31.mta1.migadu.com (out-31.mta1.migadu.com [IPv6:2001:41d0:203:375::1f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E0BB2106 for ; Wed, 12 Jul 2023 21:18:11 -0700 (PDT) Message-ID: <1d44fd43-376d-7dde-0298-e62feef8e36a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689221890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TWUawpQGXuuL18KlAo+tf3X2RrDshcORABMEoSEwms0=; b=xAyaszgSf3JBB3qbuHDn7labzAshbQS4r/+tLTuD0oTGRoNIi0BrBGlEIFWVi57fYniZhW 03cLREi+UDWX7YNOfwRH+c+u1vT4DGZfUfp1UWvL/GVQajw90knHNTxW89ERKI3PfoHhoI +dRYQRjsYdq/RtODGuNHtNw+vPHC2Hs= Date: Thu, 13 Jul 2023 12:17:54 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/3] fs: split off vfs_getdents function of getdents64 syscall Content-Language: en-US To: Ammar Faizi Cc: io-uring Mailing List , Jens Axboe , Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , Dave Chinner , Linux Fsdevel Mailing List , Wanpeng Li References: <20230711114027.59945-1-hao.xu@linux.dev> <20230711114027.59945-2-hao.xu@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Hao Xu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 7/12/23 21:55, Ammar Faizi wrote: > On Wed, Jul 12, 2023 at 04:03:41PM +0800, Hao Xu wrote: >> On 7/11/23 21:02, Ammar Faizi wrote: >>> On Tue, Jul 11, 2023 at 07:40:25PM +0800, Hao Xu wrote: >>>> Co-developed-by: Stefan Roesch >>>> Signed-off-by: Stefan Roesch >>>> Signed-off-by: Dominique Martinet >>>> --- >>> Since you took this, it needs your Signed-off-by. >>> >> Hi Ammar, >> I just add this signed-off-by of Stefan to resolve the checkpatch complain, >> no code change. > Both, you and Stefan are required to sign-off. The submitter is also > required to sign-off even if the submitter makes no code change. > > See https://www.kernel.org/doc/html/latest/process/submitting-patches.html: > """ > Any further SoBs (Signed-off-by:'s) following the author's SoB are from > people handling and transporting the patch, but were not involved in its > development. SoB chains should reflect the real route a patch took as it > was propagated to the maintainers and ultimately to Linus, with the > first SoB entry signalling primary authorship of a single author. > """ > > It also applies to the maintainer when they apply your patches. Hi Ammar, I see, this information is really helpful, I'll fix it in next version to make it more standardized. Thanks, Hao