public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: Re: [PATCH 0/2] ->flush() fixes
Date: Mon, 28 Sep 2020 15:23:58 +0300	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 28/09/2020 14:49, Pavel Begunkov wrote:
> It might fix flush() problems reported by syzkaller, but I haven't
> verified it. Jens, please tell if there was a good reason to have
> io_sq_thread_stop() in io_uring_flush().

It looks like it shouldn't be a problem removing it, because an
sqpoll task sets req->task to itself, and such requests are
cancelled and waited by io_uring_release() if that is required.

> 
> Pavel Begunkov (2):
>   io_uring: fix use-after-free ->files
>   io_uring: fix unsynchronised removal of sq_data
> 
>  fs/io_uring.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 

-- 
Pavel Begunkov

  parent reply	other threads:[~2020-09-28 12:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 11:49 [PATCH 0/2] ->flush() fixes Pavel Begunkov
2020-09-28 11:49 ` [PATCH 1/2] io_uring: fix use-after-free ->files Pavel Begunkov
2020-09-28 11:49 ` [PATCH 2/2] io_uring: fix unsynchronised removal of sq_data Pavel Begunkov
2020-09-28 12:23 ` Pavel Begunkov [this message]
2020-09-28 13:35 ` [PATCH 0/2] ->flush() fixes Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox