From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH for-5.6] io_uring: fix use-after-free by io_cleanup_req()
Date: Tue, 18 Feb 2020 16:13:02 -0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <a0ee1817fd82ae102607714825ed35833a7d6a3d.1582060617.git.asml.silence@gmail.com>
On 2/18/20 2:19 PM, Pavel Begunkov wrote:
> io_cleanup_req() should be called before req->io is freed, and so
> shouldn't be after __io_free_req() -> __io_req_aux_free(). Also,
> it will be ignored for in io_free_req_many(), which use
> __io_req_aux_free().
>
> Place cleanup_req() into __io_req_aux_free().
I've applied this, but would be great if you could generate 5.x
patches against io_uring-5.x. This one didn't apply, as it's
done behind some of the 5.7 series you have.
--
Jens Axboe
next prev parent reply other threads:[~2020-02-19 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 21:19 [PATCH for-5.6] io_uring: fix use-after-free by io_cleanup_req() Pavel Begunkov
2020-02-18 21:28 ` Pavel Begunkov
2020-02-19 0:13 ` Jens Axboe [this message]
2020-02-19 10:03 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox