public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring: don't unconditionally set plug->nowait = true
@ 2020-09-25 15:06 Jens Axboe
  0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2020-09-25 15:06 UTC (permalink / raw)
  To: io-uring

This causes all the bios to be submitted with REQ_NOWAIT, which can be
problematic on either btrfs or on file systems that otherwise use a mix
of block devices where only some of them support it.

For now, just remove the setting of plug->nowait = true.

Reported-by: Dan Melnic <[email protected]>
Reported-by: Brian Foster <[email protected]>
Fixes: b63534c41e20 ("io_uring: re-issue block requests that failed because of resources")
Signed-off-by: Jens Axboe <[email protected]>

---

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 0ab16df31288..ad828fa19af4 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -6353,9 +6353,6 @@ static void io_submit_state_start(struct io_submit_state *state,
 				  struct io_ring_ctx *ctx, unsigned int max_ios)
 {
 	blk_start_plug(&state->plug);
-#ifdef CONFIG_BLOCK
-	state->plug.nowait = true;
-#endif
 	state->comp.nr = 0;
 	INIT_LIST_HEAD(&state->comp.list);
 	state->comp.ctx = ctx;

-- 
Jens Axboe


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-09-25 15:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-25 15:06 [PATCH] io_uring: don't unconditionally set plug->nowait = true Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox