From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DCB1C433F5 for ; Tue, 31 May 2022 09:10:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241551AbiEaJKH (ORCPT ); Tue, 31 May 2022 05:10:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235570AbiEaJKG (ORCPT ); Tue, 31 May 2022 05:10:06 -0400 Received: from pv50p00im-hyfv10011601.me.com (pv50p00im-hyfv10011601.me.com [17.58.6.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72273443E4 for ; Tue, 31 May 2022 02:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1653988205; bh=gkhFdOG92aiYomQp2AZs9QqucYRolJ3/+E9SiBBpsY4=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; b=Z5vnjwhcmnwow12TTDQulq44WiNv2hSctOV6875pohGSIdAsH+DHKCANbSmzv03NY gv9O32Uj6h1sjbzeWDDNEoU6vel+CnuUqIK0OvcGby5IRslRQTjaNDh9K1GApABw6e UGNSCibcxOkWTaR69OeeRk9lbxs5D/cnWgCTJDoBbQyVttp604duWuyohhicGg/eXn pTDjI+hG7qHdjsE+zcCiRyACiCU2oEkJWoeIe6YWMK+8oxIXFaL0kuhwMroJCMIpV+ nz5IjqRj7Bf9qVnYsLMtym2OfVl7MQC/8dYpZ4C6EPrKA4vXQAHoLWYMtna4oU1JwC mCGoVAWwKpKnQ== Received: from [10.97.63.88] (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-hyfv10011601.me.com (Postfix) with ESMTPSA id C9FF69601C0; Tue, 31 May 2022 09:10:02 +0000 (UTC) Message-ID: <1eb545e8-c5ca-4f00-b225-d81ce8bc2b53@icloud.com> Date: Tue, 31 May 2022 17:09:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 00/11] fixed worker Content-Language: en-US To: Jens Axboe , io-uring@vger.kernel.org Cc: Pavel Begunkov References: <20220515131230.155267-1-haoxu.linux@icloud.com> <1071c09c-8670-b883-5b64-2cd1fb69d943@icloud.com> <6e0e18e8-79d6-92e5-99cc-0b074a04fb69@kernel.dk> <2e40c83a-c482-9cbb-0319-dae47e6a966d@icloud.com> From: Hao Xu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874 definitions=2022-05-31_03:2022-05-30,2022-05-31 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2009150000 definitions=main-2205310048 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 5/31/22 17:02, Jens Axboe wrote: > On 5/31/22 2:55 AM, Hao Xu wrote: >> On 5/31/22 16:46, Jens Axboe wrote: >>> On 5/31/22 1:05 AM, Hao Xu wrote: >>>> On 5/15/22 21:12, Hao Xu wrote: >>>>> From: Hao Xu >>>>> >>>>> This is the second version of fixed worker implementation. >>>>> Wrote a nop test program to test it, 3 fixed-workers VS 3 normal workers. >>>>> normal workers: >>>>> ./run_nop_wqe.sh nop_wqe_normal 200000 100 3 1-3 >>>>>           time spent: 10464397 usecs      IOPS: 1911242 >>>>>           time spent: 9610976 usecs       IOPS: 2080954 >>>>>           time spent: 9807361 usecs       IOPS: 2039284 >>>>> >>>>> fixed workers: >>>>> ./run_nop_wqe.sh nop_wqe_fixed 200000 100 3 1-3 >>>>>           time spent: 17314274 usecs      IOPS: 1155116 >>>>>           time spent: 17016942 usecs      IOPS: 1175299 >>>>>           time spent: 17908684 usecs      IOPS: 1116776 >>>>> >>>>> About 2x improvement. From perf result, almost no acct->lock contension. >>>>> Test program: https://github.com/HowHsu/liburing/tree/fixed_worker >>>>> liburing/test/nop_wqe.c >>>>> >>>>> v3->v4: >>>>>    - make work in fixed worker's private worfixed worker >>>>>    - tweak the io_wqe_acct struct to make it clearer >>>>> >>>> >>>> Hi Jens and Pavel, >>>> Any comments on this series? There are two coding style issue and I'm >>>> going to send v5, before this I'd like to get some comment if there is >>>> any. >>> >>> I'll try to find some time to review it, doing a conference this week. >> >> No worries. >> >>> Rebasing on the current for-5.20/io_uring branch would be a good idea >>> anyway. >> >> I'll do that. > > When you do, most/all patches also have: > > From: Hao Xu > > From: Hao Xu > > which is a bit confusing, so probably choose one and go with that :-) > Sure