From: Helge Deller <[email protected]>
To: Jens Axboe <[email protected]>,
Christoph Biedl <[email protected]>,
[email protected], [email protected]
Cc: Mike Rapoport <[email protected]>, Vlastimil Babka <[email protected]>
Subject: Re: [PATCH] io_uring/parisc: Adjust pgoff in io_uring mmap() for parisc
Date: Mon, 7 Aug 2023 21:33:49 +0200 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 8/7/23 20:34, Jens Axboe wrote:
>
> On Mon, 07 Aug 2023 20:04:09 +0200, Helge Deller wrote:
>> The changes from commit 32832a407a71 ("io_uring: Fix io_uring mmap() by
>> using architecture-provided get_unmapped_area()") to the parisc
>> implementation of get_unmapped_area() broke glibc's locale-gen
>> executable when running on parisc.
>>
>> This patch reverts those architecture-specific changes, and instead
>> adjusts in io_uring_mmu_get_unmapped_area() the pgoff offset which is
>> then given to parisc's get_unmapped_area() function. This is much
>> cleaner than the previous approach, and we still will get a coherent
>> addresss.
>>
>> [...]
>
> Applied, thanks!
That was fast :-)
Actually I had hoped for some more testing from Christoph and other
parisc guys first.
Anyway, since you have a parisc machine in your test ring, you will
notice if something breaks,
What's important:
Please add to the patch:
Cc: [email protected] # 6.4
Thank you!
Helge
> [1/1] io_uring/parisc: Adjust pgoff in io_uring mmap() for parisc
> commit: ce11a0688e67aae1e9ba6c8843d7e8b7dd791ead
next prev parent reply other threads:[~2023-08-07 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[email protected]>
[not found] ` <[email protected]>
[not found] ` <[email protected]>
[not found] ` <[email protected]>
[not found] ` <[email protected]>
[not found] ` <[email protected]>
2023-08-07 18:04 ` [PATCH] io_uring/parisc: Adjust pgoff in io_uring mmap() for parisc Helge Deller
2023-08-07 18:24 ` Jens Axboe
2023-08-07 18:27 ` Helge Deller
2023-08-07 18:33 ` Jens Axboe
2023-08-07 19:30 ` Helge Deller
2023-08-07 18:34 ` Jens Axboe
2023-08-07 19:33 ` Helge Deller [this message]
2023-08-07 19:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox