public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Ming Lei <[email protected]>, [email protected]
Subject: Re: [PATCH] io_uring: add IORING_OP_NOP_FAIL
Date: Wed, 8 May 2024 20:55:09 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 5/8/24 8:34 PM, Ming Lei wrote:
> Add IORING_OP_NOP_FAIL so that it is easy to inject failure from
> userspace.
> 
> Like IORING_OP_NOP, the main use case is test, and it is very helpful
> for covering failure handling code in io_uring core change.

Rather than use a new opcode for this, why don't we just add it to
the existing NOP? I know we don't check for flags in currently, so
you would not know if it worked, but we could add that and just
backport that one-liner as well.

And if we had such a flag, the fail res could be passed in as well.

-- 
Jens Axboe


  reply	other threads:[~2024-05-09  2:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-09  2:34 [PATCH] io_uring: add IORING_OP_NOP_FAIL Ming Lei
2024-05-09  2:55 ` Jens Axboe [this message]
2024-05-09  3:05   ` Ming Lei
2024-05-09  4:03     ` Ming Lei
2024-05-09 14:02     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox