From: Jens Axboe <axboe@kernel.dk>
To: Xie Maoyi <maoyi.xie@ntu.edu.sg>,
Pavel Begunkov <asml.silence@gmail.com>,
"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Question: io_uring SQPOLL fdinfo prints host PID across pid_ns?
Date: Sat, 9 May 2026 08:00:27 -0600 [thread overview]
Message-ID: <1fbe6348-581d-44c5-b1ff-966a68a9c507@kernel.dk> (raw)
In-Reply-To: <TYZPR01MB6758E1C56BE8616027964BE8DC3D2@TYZPR01MB6758.apcprd01.prod.exchangelabs.com>
On 5/8/26 2:34 AM, Xie Maoyi wrote:
> Hi Jens, Pavel,
>
> While testing io_uring with the SQPOLL setup flag from inside an
> unprivileged user_ns + pid_ns, I noticed that
> /proc/<pid>/fdinfo/<ring> prints the SQPOLL kthread's host
> (init_pid_ns) PID rather than the kthread's PID as seen from the
> caller's pid_ns. I'm not sure whether this is intended behaviour
> or a bug worth fixing, and would appreciate your view before
> sending a patch.
>
> Reproduction (KASAN, mainline 7.0): a process unshares CLONE_NEWUSER
> | CLONE_NEWPID | CLONE_NEWNS, mounts a private /proc, and a
> grandchild (PID 1 in the new pid_ns) opens an io_uring ring with
> IORING_SETUP_SQPOLL. Inside the new pid_ns:
>
> /proc/self/task contains {1, 2} # SQPOLL kthread is PID 2
> /proc/self/fdinfo/<ring>:
> SqThread: 356 # init_pid_ns view (host PID)
>
> After applying a candidate fix that translates sq->task_pid
> through task_pid_nr_ns() against the inode's pid_ns (mirroring
> pidfd_show_fdinfo() in kernel/pid.c), the same PoC prints:
>
> SqThread: 2 # caller's pid_ns view
>
> Is this expected behaviour, or worth fixing? If a fix would be
> welcome, I have a 2+/1- patch in io_uring/fdinfo.c that's
> checkpatch-clean and verified pre/post on a KASAN VM. Happy to
> send the patch and the full PoC if that's useful.
Please send the patch, I do think we should change that.
--
Jens Axboe
prev parent reply other threads:[~2026-05-09 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 8:34 Question: io_uring SQPOLL fdinfo prints host PID across pid_ns? Xie Maoyi
2026-05-09 14:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fbe6348-581d-44c5-b1ff-966a68a9c507@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maoyi.xie@ntu.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox