From: Jens Axboe <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: [PATCHSET v2] Improve io_uring cancellations
Date: Wed, 13 Nov 2019 14:32:03 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
Hot on the heels of v1, here's v2 of this patchset. Due to some
brainfart on my end, I forgot that we have the worker ref count
to prevent workers from going away. So we don't need the ->exiting
change from v1. The other two items were totally valid, however.
To summarize, they are:
- While the wqe->lock protects the stability of the worker->cur_work
pointer, it does NOT stabilize the actual work item. For cancelling
specific work, io_uring needs to dereference it to see if it matches.
- We're not consistent in comparing worker->cur_work and sending a
signal to cancel it.
These three patches fix the above issues. The first is a prep patch that
adds referencing of work items, which makes it safe to dereference
->cur_work if we ensure that ->cur_work itself is stable. The second
closes the hole that currently exists with signaling specific work for
cancellation, and the last one closes a tiny hole where we might miss a
worker during list iteration.
Changes since v1:
- Get rid of ->exiting, we don't need it
- Add third patch on closing list iteration hole
fs/io-wq.c | 113 +++++++++++++++++++++++++++-----------------------
fs/io-wq.h | 7 +++-
fs/io_uring.c | 17 +++++++-
3 files changed, 84 insertions(+), 53 deletions(-)
--
Jens Axboe
next reply other threads:[~2019-11-13 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 21:32 Jens Axboe [this message]
2019-11-13 21:32 ` [PATCH 1/3] io_wq: add get/put_work handlers to io_wq_create() Jens Axboe
2019-11-13 21:32 ` [PATCH 2/3] io-wq: ensure we have a stable view of ->cur_work for cancellations Jens Axboe
2019-11-13 21:32 ` [PATCH 3/3] io-wq: ensure free/busy list browsing see all items Jens Axboe
2019-11-13 23:42 ` Paul E. McKenney
2019-11-14 2:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox