From: Stefano Garzarella <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH liburing 1/1] test: add epoll test case
Date: Tue, 28 Jan 2020 14:06:46 +0100 [thread overview]
Message-ID: <20200128130646.n3x5co7n3m7gbyzy@steredhat> (raw)
In-Reply-To: <[email protected]>
On Mon, Jan 27, 2020 at 11:46:34AM -0700, Jens Axboe wrote:
> On 1/27/20 11:25 AM, Stefano Garzarella wrote:
> > On Mon, Jan 27, 2020 at 09:32:43AM -0700, Jens Axboe wrote:
> >> On 1/27/20 9:17 AM, Stefano Garzarella wrote:
> >>> Signed-off-by: Stefano Garzarella <[email protected]>
> >>
> >> You're not reaping CQ events, and hence you overflow the ring. Once
> >> overflown, an attempt to submit new IO will returns in a -16/-EBUSY
> >> return value. This is io_uring telling you that it won't submit more
> >> IO until you've emptied the completion ring so io_uring can flush
> >> the overflown entries to the ring.
> >
> > How can I reaping CQ events? (I was hoping the epoll would help me with that)
> >
> > What I'm seeing is that the producer (EPOLLOUT) can fill the SQ without issues,
> > the consumer (read()) is receiving all the buffers produced, but the thread
> > that frees the buffers (EPOLLIN) is not woken up.
> >
> > I tried to set a timeout to the epoll_wait(), but the io_uring_peek_cqe()
> > returns -EAGAIN.
> >
> > If I'm using a ring with 16 entries, it seems to work better, but
> > sometimes I lose events and the thread that frees the buffer doesn't wake up.
> >
> > Maybe I'm missing something...
>
> OK, so that helps in terms of understanding the issue you are seeing with
> it. I'll take a look at this, but it'll probably be a few days. You can
> try and enable tracing, I see events completed just fine. Maybe a race
> with your epoll wait and event reaping?
(discard previous email wrongly sent by my phone, sorry for the noise)
Okay, the issue was that my kernel doesn’t support IORING_FEAT_NODROP,
so for this reason I missed the CQ events.
Avoiding the CQ overflow keeping this condition true
(submitted - completed < n_entries), solves the issue.
I’ll try with a mainline kernel, handling also the -EBUSY returned by
io_uring_submit().
Thanks,
Stefano
next prev parent reply other threads:[~2020-01-28 13:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 16:17 [PATCH liburing 0/1] test: add epoll test case Stefano Garzarella
2020-01-27 16:17 ` [PATCH liburing 1/1] " Stefano Garzarella
2020-01-27 16:32 ` Jens Axboe
2020-01-27 18:25 ` Stefano Garzarella
2020-01-27 18:46 ` Jens Axboe
2020-01-27 18:50 ` Stefano Garzarella
2020-01-28 13:06 ` Stefano Garzarella [this message]
2020-01-27 16:26 ` [PATCH liburing 0/1] " Jens Axboe
2020-01-27 18:00 ` Stefano Garzarella
2020-01-27 18:07 ` Jens Axboe
2020-01-27 18:28 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128130646.n3x5co7n3m7gbyzy@steredhat \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox