From: Christoph Hellwig <[email protected]>
To: Bijan Mottahedeh <[email protected]>
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH 1/1] block: Manage bio references so the bio persists until necessary
Date: Thu, 30 Jan 2020 22:42:30 -0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Thu, Jan 30, 2020 at 07:23:42PM -0800, Bijan Mottahedeh wrote:
> Get a reference to a bio, so it won't be freed if end_io() gets to
> it before submit_io() returns. Defer the release of the first bio
> in a mult-bio request until the last end_io() since the first bio is
> embedded in the dio structure and must therefore persist through an
> entire multi-bio request.
Can you explain the issue a little more?
The initial bio is embedded into the dio, and will have a reference
until the bio_put call at the end of the function, so we can't have
a race for that one and won't ever need the refcount for the single
bio case. Avoiding the atomic is pretty important for aio/uring
performance.
next prev parent reply other threads:[~2020-01-31 6:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 3:23 [PATCH 0/1] block: Manage bio references so the bio persists until necessary Bijan Mottahedeh
2020-01-31 3:23 ` [PATCH 1/1] " Bijan Mottahedeh
2020-01-31 6:42 ` Christoph Hellwig [this message]
2020-01-31 18:08 ` Bijan Mottahedeh
2020-02-03 8:34 ` Christoph Hellwig
2020-02-03 21:07 ` Bijan Mottahedeh
2020-02-04 7:51 ` Christoph Hellwig
2020-02-04 20:59 ` Jens Axboe
2020-02-04 22:41 ` Bijan Mottahedeh
2020-02-24 23:32 ` Bijan Mottahedeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox