From: Stefano Garzarella <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH liburing v2 0/1] test: add epoll test case
Date: Fri, 7 Feb 2020 17:51:36 +0100 [thread overview]
Message-ID: <20200207165136.obdezxvcws4eupbu@steredhat> (raw)
In-Reply-To: <[email protected]>
On Fri, Jan 31, 2020 at 08:39:46AM -0700, Jens Axboe wrote:
> On 1/31/20 7:29 AM, Stefano Garzarella wrote:
> > Hi Jens,
> > this is a v2 of the epoll test.
> >
> > v1 -> v2:
> > - if IORING_FEAT_NODROP is not available, avoid to overflow the CQ
> > - add 2 new tests to test epoll with IORING_FEAT_NODROP
> > - cleanups
> >
> > There are 4 sub-tests:
> > 1. test_epoll
> > 2. test_epoll_sqpoll
> > 3. test_epoll_nodrop
> > 4. test_epoll_sqpoll_nodrop
> >
> > In the first 2 tests, I try to avoid to queue more requests than we have room
> > for in the CQ ring. These work fine, I have no faults.
>
> Thanks!
>
> > In the tests 3 and 4, if IORING_FEAT_NODROP is supported, I try to submit as
> > much as I can until I get a -EBUSY, but they often fail in this way:
> > the submitter manages to submit everything, the receiver receives all the
> > submitted bytes, but the cleaner loses completion events (I also tried to put a
> > timeout to epoll_wait() in the cleaner to be sure that it is not related to the
> > patch that I send some weeks ago, but the situation doesn't change, it's like
> > there is still overflow in the CQ).
> >
> > Next week I'll try to investigate better which is the problem.
>
> Does it change if you have an io_uring_enter() with GETEVENTS set? I wonder if
> you just pruned the CQ ring but didn't flush the internal side.
>
Just an update: after the "io_uring: flush overflowed CQ events in the
io_uring_poll()" the test 3 works well.
Now the problem is the test 4 (with sqpoll). It works in most cases, but it
fails a few times in this way:
- the submitter freezes after submitting X requests
- the cleaner and the consumer see X-2 requests (2 are the entries in
the queue)
I tried to put a timeout on the submitter's epoll and do an io_uring_submit()
to wake up the kthread (if we lose some notifications), but the problem seems
to be somewhere else. I think a race somewhere.
Any suggestion on how to debug this case?
I'll try with tracing.
Thanks,
Stefano
prev parent reply other threads:[~2020-02-07 16:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 14:29 [PATCH liburing v2 0/1] test: add epoll test case Stefano Garzarella
2020-01-31 14:29 ` [PATCH liburing v2 1/1] " Stefano Garzarella
2020-01-31 15:41 ` Jens Axboe
2020-02-03 9:04 ` Stefano Garzarella
2020-02-03 15:43 ` Jens Axboe
2020-01-31 15:39 ` [PATCH liburing v2 0/1] " Jens Axboe
2020-02-03 9:03 ` Stefano Garzarella
2020-02-06 17:33 ` Stefano Garzarella
2020-02-06 19:15 ` Jens Axboe
2020-02-06 19:51 ` Jens Axboe
2020-02-06 20:12 ` Stefano Garzarella
2020-02-06 19:46 ` Jens Axboe
2020-02-07 16:51 ` Stefano Garzarella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207165136.obdezxvcws4eupbu@steredhat \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox