public inbox for [email protected]
 help / color / mirror / Atom feed
From: Greg KH <[email protected]>
To: Stefano Garzarella <[email protected]>
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH 5.4] io_uring: prevent sq_thread from spinning when it should stop
Date: Thu, 27 Feb 2020 13:37:53 +0100	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Thu, Feb 27, 2020 at 11:43:11AM +0100, Stefano Garzarella wrote:
> [ Upstream commit 7143b5ac5750f404ff3a594b34fdf3fc2f99f828 ]
> 
> This patch drops 'cur_mm' before calling cond_resched(), to prevent
> the sq_thread from spinning even when the user process is finished.
> 
> Before this patch, if the user process ended without closing the
> io_uring fd, the sq_thread continues to spin until the
> 'sq_thread_idle' timeout ends.
> 
> In the worst case where the 'sq_thread_idle' parameter is bigger than
> INT_MAX, the sq_thread will spin forever.
> 
> Fixes: 6c271ce2f1d5 ("io_uring: add submission polling")
> Signed-off-by: Stefano Garzarella <[email protected]>
> Signed-off-by: Jens Axboe <[email protected]>
> ---
>  fs/io_uring.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

thanks for this, now queued up.

greg k-h

      reply	other threads:[~2020-02-27 12:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 10:43 [PATCH 5.4] io_uring: prevent sq_thread from spinning when it should stop Stefano Garzarella
2020-02-27 12:37 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox