public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring:fix missing 'return' in comment
@ 2020-03-25  3:31 Chucheng Luo
  2020-03-25  3:48 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Chucheng Luo @ 2020-03-25  3:31 UTC (permalink / raw)
  To: Alexander Viro, Jens Axboe, linux-fsdevel, io-uring, linux-kernel
  Cc: kernel, Chucheng Luo

the missing 'return' work may make it hard
for other developers to understand it.

Signed-off-by: Chucheng Luo <[email protected]>
---
 fs/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 5a826017ebb8..4b971c7b4483 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2379,7 +2379,7 @@ static int io_write(struct io_kiocb *req, struct io_kiocb **nxt,
 		else
 			ret2 = loop_rw_iter(WRITE, req->file, kiocb, &iter);
 		/*
-		 * Raw bdev writes will -EOPNOTSUPP for IOCB_NOWAIT. Just
+		 * Raw bdev writes will return -EOPNOTSUPP for IOCB_NOWAIT. Just
 		 * retry them without IOCB_NOWAIT.
 		 */
 		if (ret2 == -EOPNOTSUPP && (kiocb->ki_flags & IOCB_NOWAIT))
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] io_uring:fix missing 'return' in comment
  2020-03-25  3:31 [PATCH] io_uring:fix missing 'return' in comment Chucheng Luo
@ 2020-03-25  3:48 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-03-25  3:48 UTC (permalink / raw)
  To: Chucheng Luo, Alexander Viro, linux-fsdevel, io-uring,
	linux-kernel; +Cc: kernel

On 3/24/20 9:31 PM, Chucheng Luo wrote:
> the missing 'return' work may make it hard
> for other developers to understand it.

Thanks, that does read better. Notes for future patches:

- You should capitalize the first letter in the commit message,
  any sentence really.
- Commit messages should use 72-74 chars of line width
- Add a space after 'io_uring:' and title description

I fixed these up and hand applied to for-5.7/io_uring.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-25  3:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-25  3:31 [PATCH] io_uring:fix missing 'return' in comment Chucheng Luo
2020-03-25  3:48 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox