From: Greg KH <[email protected]>
To: Christoph Hellwig <[email protected]>
Cc: Linus Torvalds <[email protected]>,
Andrew Morton <[email protected]>,
Al Viro <[email protected]>,
Felix Kuehling <[email protected]>,
Alex Deucher <[email protected]>,
Zhenyu Wang <[email protected]>,
Zhi Wang <[email protected]>, Felipe Balbi <[email protected]>,
"Michael S. Tsirkin" <[email protected]>,
Jason Wang <[email protected]>, Jens Axboe <[email protected]>,
[email protected], [email protected],
[email protected],
[email protected], [email protected],
[email protected],
[email protected], [email protected],
[email protected]
Subject: Re: [PATCH 3/3] kernel: set USER_DS in kthread_use_mm
Date: Thu, 16 Apr 2020 08:43:11 +0200 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Thu, Apr 16, 2020 at 07:31:58AM +0200, Christoph Hellwig wrote:
> Some architectures like arm64 and s390 require USER_DS to be set for
> kernel threads to access user address space, which is the whole purpose
> of kthread_use_mm, but other like x86 don't. That has lead to a huge
> mess where some callers are fixed up once they are tested on said
> architectures, while others linger around and yet other like io_uring
> try to do "clever" optimizations for what usually is just a trivial
> asignment to a member in the thread_struct for most architectures.
>
> Make kthread_use_mm set USER_DS, and kthread_unuse_mm restore to the
> previous value instead.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
> Acked-by: Michael S. Tsirkin <[email protected]> [vhost]
> ---
Acked-by: Greg Kroah-Hartman <[email protected]> [usb]
next prev parent reply other threads:[~2020-04-16 6:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 5:31 improve use_mm / unuse_mm v2 Christoph Hellwig
2020-04-16 5:31 ` [PATCH 1/3] kernel: move use_mm/unuse_mm to kthread.c Christoph Hellwig
2020-04-16 5:31 ` [PATCH 2/3] kernel: better document the use_mm/unuse_mm API contract Christoph Hellwig
2020-04-16 6:43 ` Greg KH
2020-04-16 5:31 ` [PATCH 3/3] kernel: set USER_DS in kthread_use_mm Christoph Hellwig
2020-04-16 6:43 ` Greg KH [this message]
2020-04-17 3:17 ` improve use_mm / unuse_mm v2 Matthew Wilcox
2020-04-17 6:31 ` Christoph Hellwig
2020-04-17 14:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox