From: Aleksa Sarai <[email protected]>
To: Cyril Hrubis <[email protected]>
Cc: kernel test robot <[email protected]>,
Josh Triplett <[email protected]>,
[email protected], Jens Axboe <[email protected]>,
Arnd Bergmann <[email protected]>,
[email protected], [email protected],
Alexander Viro <[email protected]>,
[email protected], [email protected],
[email protected]
Subject: Re: [LTP] [fs] ce436509a8: ltp.openat203.fail
Date: Tue, 28 Apr 2020 10:51:26 +1000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20200427142733.GD7661@rei>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On 2020-04-27, Cyril Hrubis <[email protected]> wrote:
> Hi!
> > commit: ce436509a8e109330c56bb4d8ec87d258788f5f4 ("[PATCH v4 2/3] fs: openat2: Extend open_how to allow userspace-selected fds")
> > url: https://github.com/0day-ci/linux/commits/Josh-Triplett/Support-userspace-selected-fds/20200414-102939
> > base: https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git next
>
> This commit adds fd parameter to the how structure where LTP test was
> previously passing garbage, which obviously causes the difference in
> errno.
>
> This could be safely ignored for now, if the patch gets merged the test
> needs to be updated.
It wouldn't be a bad idea to switch the test to figure out the ksize of
the struct, so that you only add bad padding after that. But then again,
this would be a bit ugly -- having CHECK_FIELDS would make this simpler.
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-04-28 0:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 2:14 [PATCH v4 0/3] Support userspace-selected fds Josh Triplett
2020-04-14 2:15 ` [PATCH v4 1/3] fs: Support setting a minimum fd for "lowest available fd" allocation Josh Triplett
2020-04-14 2:15 ` [PATCH v4 2/3] fs: openat2: Extend open_how to allow userspace-selected fds Josh Triplett
2020-04-19 10:44 ` Aleksa Sarai
2020-04-19 21:18 ` David Laight
2020-04-19 22:22 ` Jens Axboe
2020-04-20 2:06 ` Aleksa Sarai
2020-04-20 21:14 ` Josh Triplett
[not found] ` <20200427135210.GB5770@shao2-debian>
2020-04-27 14:27 ` [LTP] [fs] ce436509a8: ltp.openat203.fail Cyril Hrubis
2020-04-28 0:51 ` Aleksa Sarai [this message]
2020-04-28 15:30 ` Cyril Hrubis
2020-04-28 15:35 ` Aleksa Sarai
2020-04-14 2:16 ` [PATCH v4 3/3] fs: pipe2: Support O_SPECIFIC_FD Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428005126.6wncibudt6ohghvc@yavin.dot.cyphar.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox