public inbox for [email protected]
 help / color / mirror / Atom feed
From: "Milan P. Stanić" <[email protected]>
To: [email protected]
Subject: Build 0.6 version fail on musl libc
Date: Tue, 28 Apr 2020 21:29:56 +0200	[thread overview]
Message-ID: <[email protected]> (raw)

Hello,

I'm liburing Alpine Linux maintainer
(https://git.alpinelinux.org/aports/tree/testing/liburing)

I tried to upgrade to 0.6 from 0.5 version but I got errors:
include/liburing/compat.h:6:2: error: unknown type name 'int64_t'
and
include/liburing.h:196:17: error: unknown type name 'loff_t'; did you mean 'off_t'?

musl libc have /usr/include/fcntl.h in which loff_t is defined with:
#define loff_t off_t
and I tried to include it in include/liburing.h but this didn't helped.

After this I created this patch:
------
--- a/src/include/liburing.h	2020-04-13 18:50:21.000000000 +0200
+++ b/src/include/liburing.h	2020-04-23 21:43:15.923487287 +0200
@@ -193,8 +193,8 @@
 }
 
 static inline void io_uring_prep_splice(struct io_uring_sqe *sqe,
-					int fd_in, loff_t off_in,
-					int fd_out, loff_t off_out,
+					int fd_in, off_t off_in,
+					int fd_out, off_t off_out,
 					unsigned int nbytes,
 					unsigned int splice_flags)
 {
------
with which version 0.6 builds fine but I suspect this is not proper fix.

Could you, please, give me advice what will be proper fix these changes?

-- 
regards

             reply	other threads:[~2020-04-28 20:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 19:29 Milan P. Stanić [this message]
2020-04-29 15:24 ` Build 0.6 version fail on musl libc Jens Axboe
2020-04-29 15:26   ` Christoph Hellwig
2020-04-29 15:29     ` Jens Axboe
2020-04-29 16:14       ` Jens Axboe
2020-04-29 19:33         ` Milan P. Stanić
2020-04-29 19:38           ` Jens Axboe
2020-04-29 20:01             ` Milan P. Stanić
2020-04-29 20:08               ` Jens Axboe
2020-04-29 20:38                 ` Milan P. Stanić
2020-04-29 20:43                   ` Jens Axboe
2020-04-29 20:48                     ` Milan P. Stanić
2020-04-30 14:38                     ` Milan P. Stanić
2020-04-30 14:47                       ` Jens Axboe
2020-04-30 15:56                         ` Milan P. Stanić
2020-04-29 19:36         ` Jann Horn
2020-04-29 19:38           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox