public inbox for [email protected]
 help / color / mirror / Atom feed
From: Christoph Hellwig <[email protected]>
To: Jens Axboe <[email protected]>
Cc: "Milan P. Stanić" <[email protected]>, [email protected]
Subject: Re: Build 0.6 version fail on musl libc
Date: Wed, 29 Apr 2020 08:26:46 -0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Wed, Apr 29, 2020 at 09:24:40AM -0600, Jens Axboe wrote:
> 
> Not sure what the best fix is there, for 32-bit, your change will truncate
> the offset to 32-bit as off_t is only 4 bytes there. At least that's the
> case for me, maybe musl is different if it just has a nasty define for
> them.
> 
> Maybe best to just make them uint64_t or something like that.

The proper LFS type would be off64_t.

  reply	other threads:[~2020-04-29 15:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 19:29 Build 0.6 version fail on musl libc Milan P. Stanić
2020-04-29 15:24 ` Jens Axboe
2020-04-29 15:26   ` Christoph Hellwig [this message]
2020-04-29 15:29     ` Jens Axboe
2020-04-29 16:14       ` Jens Axboe
2020-04-29 19:33         ` Milan P. Stanić
2020-04-29 19:38           ` Jens Axboe
2020-04-29 20:01             ` Milan P. Stanić
2020-04-29 20:08               ` Jens Axboe
2020-04-29 20:38                 ` Milan P. Stanić
2020-04-29 20:43                   ` Jens Axboe
2020-04-29 20:48                     ` Milan P. Stanić
2020-04-30 14:38                     ` Milan P. Stanić
2020-04-30 14:47                       ` Jens Axboe
2020-04-30 15:56                         ` Milan P. Stanić
2020-04-29 19:36         ` Jann Horn
2020-04-29 19:38           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox