From: Stefano Garzarella <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected]
Subject: [PATCH liburing 3/5] Add helpers to set and get eventfd notification status
Date: Fri, 15 May 2020 18:43:29 +0200 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
This patch adds the new IORING_CQ_EVENTFD_DISABLED flag. It can be
used to disable/enable notifications from the kernel when a
request is completed and queued to the CQ ring.
We also add two helpers function to check if the notifications are
enabled and to enable/disable them.
If the kernel doesn't provide CQ ring flags, the notifications are
always enabled if an eventfd is registered.
Signed-off-by: Stefano Garzarella <[email protected]>
---
src/include/liburing.h | 30 ++++++++++++++++++++++++++++++
src/include/liburing/io_uring.h | 7 +++++++
2 files changed, 37 insertions(+)
diff --git a/src/include/liburing.h b/src/include/liburing.h
index ea596f6..fe03547 100644
--- a/src/include/liburing.h
+++ b/src/include/liburing.h
@@ -9,7 +9,9 @@ extern "C" {
#include <sys/socket.h>
#include <sys/uio.h>
#include <sys/stat.h>
+#include <errno.h>
#include <signal.h>
+#include <stdbool.h>
#include <inttypes.h>
#include <time.h>
#include "liburing/compat.h"
@@ -445,6 +447,34 @@ static inline unsigned io_uring_cq_ready(struct io_uring *ring)
return io_uring_smp_load_acquire(ring->cq.ktail) - *ring->cq.khead;
}
+static inline int io_uring_cq_eventfd_enable(struct io_uring *ring,
+ bool enabled)
+{
+ uint32_t flags;
+
+ if (!ring->cq.kflags)
+ return -ENOTSUP;
+
+ flags = *ring->cq.kflags;
+
+ if (enabled)
+ flags &= ~IORING_CQ_EVENTFD_DISABLED;
+ else
+ flags |= IORING_CQ_EVENTFD_DISABLED;
+
+ IO_URING_WRITE_ONCE(*ring->cq.kflags, flags);
+
+ return 0;
+}
+
+static inline bool io_uring_cq_eventfd_enabled(struct io_uring *ring)
+{
+ if (!ring->cq.kflags)
+ return true;
+
+ return !(*ring->cq.kflags & IORING_CQ_EVENTFD_DISABLED);
+}
+
static int __io_uring_peek_cqe(struct io_uring *ring, struct io_uring_cqe **cqe_ptr)
{
struct io_uring_cqe *cqe;
diff --git a/src/include/liburing/io_uring.h b/src/include/liburing/io_uring.h
index 602bb0e..8c5775d 100644
--- a/src/include/liburing/io_uring.h
+++ b/src/include/liburing/io_uring.h
@@ -209,6 +209,13 @@ struct io_cqring_offsets {
__u64 resv2;
};
+/*
+ * cq_ring->flags
+ */
+
+/* disable eventfd notifications */
+#define IORING_CQ_EVENTFD_DISABLED (1U << 0)
+
/*
* io_uring_enter(2) flags
*/
--
2.25.4
next prev parent reply other threads:[~2020-05-15 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 16:43 [PATCH liburing 0/5] liburing: add helpers to enable/disable eventfd notifications Stefano Garzarella
2020-05-15 16:43 ` [PATCH liburing 1/5] Add CQ ring 'flags' field Stefano Garzarella
2020-05-15 16:43 ` [PATCH liburing 2/5] man/io_uring_setup.2: add 'flags' field in the struct io_cqring_offsets Stefano Garzarella
2020-05-15 16:43 ` Stefano Garzarella [this message]
2020-05-15 16:53 ` [PATCH liburing 3/5] Add helpers to set and get eventfd notification status Jens Axboe
2020-05-15 17:11 ` Stefano Garzarella
2020-05-20 13:12 ` Stefano Garzarella
2020-05-20 13:43 ` Jens Axboe
2020-05-20 15:11 ` Stefano Garzarella
2020-05-20 15:19 ` Jens Axboe
2020-05-15 16:43 ` [PATCH liburing 4/5] man/io_uring_register.2: add IORING_CQ_EVENTFD_DISABLED description Stefano Garzarella
2020-05-15 16:43 ` [PATCH liburing 5/5] Add test/eventfd-disable.c test case Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox