public inbox for [email protected]
 help / color / mirror / Atom feed
From: Bart Van Assche <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], Bart Van Assche <[email protected]>
Subject: [PATCH liburing 1/3] Makefiles: Enable -Wextra
Date: Sun, 21 Jun 2020 13:36:44 -0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Enable -Wextra and disable the unused parameter and different signedness
in comparison warnings.

Signed-off-by: Bart Van Assche <[email protected]>
---
 src/Makefile  | 3 ++-
 test/Makefile | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/Makefile b/src/Makefile
index 9bbbacf03d59..3099f7cd51ec 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -4,7 +4,8 @@ libdir ?= $(prefix)/lib
 libdevdir ?= $(prefix)/lib
 
 CFLAGS ?= -g -fomit-frame-pointer -O2
-override CFLAGS += -Wall -Iinclude/ -include ../config-host.h
+override CFLAGS += -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare\
+	-Iinclude/ -include ../config-host.h
 SO_CFLAGS=-shared -fPIC $(CFLAGS)
 L_CFLAGS=$(CFLAGS)
 LINK_FLAGS=
diff --git a/test/Makefile b/test/Makefile
index 93e58f4ba9b0..e103296fabdd 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -5,7 +5,9 @@ INSTALL=install
 
 CFLAGS ?= -g -O2
 XCFLAGS =
-override CFLAGS += -Wall -D_GNU_SOURCE -L../src/ -I../src/include/ -include ../config-host.h -D__SANE_USERSPACE_TYPES__
+override CFLAGS += -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare\
+	-D_GNU_SOURCE -D__SANE_USERSPACE_TYPES__ -L../src/ \
+	-I../src/include/ -include ../config-host.h
 
 all_targets += poll poll-cancel ring-leak fsync io_uring_setup io_uring_register \
 	       io_uring_enter nop sq-full cq-full 35fa71a030ca-test \

  reply	other threads:[~2020-06-21 20:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-21 20:36 [PATCH liburing 0/3] Three small liburing patches Bart Van Assche
2020-06-21 20:36 ` Bart Van Assche [this message]
2020-06-21 20:36 ` [PATCH liburing 2/3] src/include/liburing/barrier.h: Use C11 atomics Bart Van Assche
2020-06-21 20:36 ` [PATCH liburing 3/3] Convert __io_uring_get_sqe() from a macro into an inline function Bart Van Assche
2020-06-22  2:50 ` [PATCH liburing 0/3] Three small liburing patches Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox