From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 188F5C433E0 for ; Thu, 9 Jul 2020 10:17:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E66E520674 for ; Thu, 9 Jul 2020 10:17:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GBV5Mmfd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbgGIKRk (ORCPT ); Thu, 9 Jul 2020 06:17:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbgGIKRj (ORCPT ); Thu, 9 Jul 2020 06:17:39 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8220C061A0B; Thu, 9 Jul 2020 03:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LRPqrhsNrVoCtzLxk2wePAErWiLop2DSkjv1pIhjoHg=; b=GBV5Mmfdm2akDAsfJJUzUXaw06 1X1qfTTyW7QEtBEjfGD5qe55tU/LYxGUNuvdSK+mdIV4lZoO2isTN9NMUkHIDvypM/Tlgf5Bzz0LD DdwJCG+atOIh2kmNiDGNlspUcMKRsBs3MyF7jeuin83VXsC0vf4EkvI1RSQ1rIQBf/ypJn56hlmnf jmep2fHi3S9ott/V3ERLi/TmjgCTRunpQUwcs6eg7ZckXDF2ZisSHei0QxENA9Jp+ar9H6rlz7q+l JiO63nNcvO9IqyjV3r2oaQJPy49Y0StY0EludsHDgPjq+iVbkN0mPvPmIREoRDU/AnNEt/OHSb3OS 7yLXvO0A==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtTc1-0000aq-Tc; Thu, 09 Jul 2020 10:17:05 +0000 Date: Thu, 9 Jul 2020 11:17:05 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Jens Axboe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Kanchan Joshi , Javier Gonzalez Subject: Re: [PATCH 0/2] Remove kiocb ki_complete Message-ID: <20200709101705.GA2095@infradead.org> References: <20200708222637.23046-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200708222637.23046-1-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org I really don't like this series at all. If saves a single pointer but introduces a complicated machinery that just doesn't follow any natural flow. And there doesn't seem to be any good reason for it to start with.