From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECBF7C433E3 for ; Fri, 10 Jul 2020 13:09:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C04B52082E for ; Fri, 10 Jul 2020 13:09:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="tr6Eaqfm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726872AbgGJNJc (ORCPT ); Fri, 10 Jul 2020 09:09:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726828AbgGJNJb (ORCPT ); Fri, 10 Jul 2020 09:09:31 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D3EEC08C5CE; Fri, 10 Jul 2020 06:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NZEm5kzXLSFX2uBu54Q0aqlOoQJepX9jlZjRW+QQTkw=; b=tr6Eaqfm9KyxXHuJMhAte2ZWyv aVsZJEWGYxlDflnFN4o7pToRfOf2n3IgeEy9QK+jOxSUH0v6L9rNedztx5aw2zYTrGcRzPrR4eROj Ek+Ub/VhMABoNVTenSTaf524sNeUiWS5MiA7EqjQw6ppbOyfc7fzB2KorQNu3s5+wgF1dP6JCSlHY bjDNfOO6JS4T4XL8+yUwKU3Oxuy2mASVyYxVouUPt4VPpz6L1J4bMtMOCl4ejE/e061xHf7G4aOi5 yA/koxNGruZrjBLNKp4qg2UDUelZV9PpNAzuyUK2O6rtoG0L4HV3D6Z2na03mPGQRKQQq99yry4Bf jDHufJqg==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtsm8-000266-Hp; Fri, 10 Jul 2020 13:09:12 +0000 Date: Fri, 10 Jul 2020 14:09:12 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Kanchan Joshi , Christoph Hellwig , Kanchan Joshi , viro@zeniv.linux.org.uk, bcrl@kvack.org, Damien.LeMoal@wdc.com, asml.silence@gmail.com, linux-fsdevel@vger.kernel.org, Matias Bj??rling , linux-kernel@vger.kernel.org, linux-aio@kvack.org, io-uring@vger.kernel.org, linux-block@vger.kernel.org, Selvakumar S , Nitesh Shetty , Javier Gonzalez Subject: Re: [PATCH v3 4/4] io_uring: add support for zone-append Message-ID: <20200710130912.GA7491@infradead.org> References: <1593974870-18919-1-git-send-email-joshi.k@samsung.com> <1593974870-18919-5-git-send-email-joshi.k@samsung.com> <20200709085501.GA64935@infradead.org> <20200709140053.GA7528@infradead.org> <2270907f-670c-5182-f4ec-9756dc645376@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Thu, Jul 09, 2020 at 12:50:27PM -0600, Jens Axboe wrote: > It might, if you have IRQ context for the completion. task_work isn't > expensive, however. It's not like a thread offload. > > > Using flags have not been liked here, but given the upheaval involved so > > far I have begun to feel - it was keeping things simple. Should it be > > reconsidered? > > It's definitely worth considering, especially since we can use cflags > like Pavel suggested upfront and not need any extra storage. But it > brings us back to the 32-bit vs 64-bit discussion, and then using blocks > instead of bytes. Which isn't exactly super pretty. block doesn't work for the case of writes to files that don't have to be aligned in any way. And that I think is the more broadly applicable use case than zone append on block devices.