public inbox for [email protected]
 help / color / mirror / Atom feed
From: Tobias Klauser <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] test/statx: verify against statx(2) on all archs
Date: Fri, 10 Jul 2020 16:25:03 +0200	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2020-07-10 at 15:55:24 +0200, Jens Axboe <[email protected]> wrote:
> On 7/9/20 3:34 PM, Tobias Klauser wrote:
> > Use __NR_statx in do_statx and unconditionally use it to check the
> > result on all architectures, not just x86_64. This relies on the
> > fact that __NR_statx should be defined if struct statx and STATX_ALL are
> > available as well.
> > 
> > Don't fail the test if the statx syscall returns EOPNOTSUPP though.
> 
> Applied, thanks.

And thanks for your follow-up fix! Looking at it I noticed that
statx_syscall_supported introduced by this change should check for
ENOSYS, not EOPNOTSUPP. Will send another follow-up.

  reply	other threads:[~2020-07-10 14:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 21:34 [PATCH] test/statx: verify against statx(2) on all archs Tobias Klauser
2020-07-10 13:55 ` Jens Axboe
2020-07-10 14:25   ` Tobias Klauser [this message]
2020-07-10 14:27     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox