From: Stefano Garzarella <[email protected]>
To: Pavel Begunkov <[email protected]>, Jens Axboe <[email protected]>
Cc: Alexander Viro <[email protected]>,
Kernel Hardening <[email protected]>,
Kees Cook <[email protected]>, Aleksa Sarai <[email protected]>,
Stefan Hajnoczi <[email protected]>,
Christian Brauner <[email protected]>,
Sargun Dhillon <[email protected]>, Jann Horn <[email protected]>,
[email protected], [email protected],
Jeff Moyer <[email protected]>,
[email protected]
Subject: Re: [PATCH RFC v2 1/3] io_uring: use an enumeration for io_uring_register(2) opcodes
Date: Fri, 17 Jul 2020 10:13:33 +0200 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Thu, Jul 16, 2020 at 03:20:53PM -0600, Jens Axboe wrote:
> On 7/16/20 2:51 PM, Jens Axboe wrote:
> > On 7/16/20 2:47 PM, Pavel Begunkov wrote:
> >> On 16/07/2020 23:42, Jens Axboe wrote:
> >>> On 7/16/20 2:16 PM, Pavel Begunkov wrote:
> >>>> On 16/07/2020 15:48, Stefano Garzarella wrote:
> >>>>> The enumeration allows us to keep track of the last
> >>>>> io_uring_register(2) opcode available.
> >>>>>
> >>>>> Behaviour and opcodes names don't change.
> >>>>>
> >>>>> Signed-off-by: Stefano Garzarella <[email protected]>
> >>>>> ---
> >>>>> include/uapi/linux/io_uring.h | 27 ++++++++++++++++-----------
> >>>>> 1 file changed, 16 insertions(+), 11 deletions(-)
> >>>>>
> >>>>> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
> >>>>> index 7843742b8b74..efc50bd0af34 100644
> >>>>> --- a/include/uapi/linux/io_uring.h
> >>>>> +++ b/include/uapi/linux/io_uring.h
> >>>>> @@ -253,17 +253,22 @@ struct io_uring_params {
> >>>>> /*
> >>>>> * io_uring_register(2) opcodes and arguments
> >>>>> */
> >>>>> -#define IORING_REGISTER_BUFFERS 0
> >>>>> -#define IORING_UNREGISTER_BUFFERS 1
> >>>>> -#define IORING_REGISTER_FILES 2
> >>>>> -#define IORING_UNREGISTER_FILES 3
> >>>>> -#define IORING_REGISTER_EVENTFD 4
> >>>>> -#define IORING_UNREGISTER_EVENTFD 5
> >>>>> -#define IORING_REGISTER_FILES_UPDATE 6
> >>>>> -#define IORING_REGISTER_EVENTFD_ASYNC 7
> >>>>> -#define IORING_REGISTER_PROBE 8
> >>>>> -#define IORING_REGISTER_PERSONALITY 9
> >>>>> -#define IORING_UNREGISTER_PERSONALITY 10
> >>>>> +enum {
> >>>>> + IORING_REGISTER_BUFFERS,
> >>>>> + IORING_UNREGISTER_BUFFERS,
> >>>>> + IORING_REGISTER_FILES,
> >>>>> + IORING_UNREGISTER_FILES,
> >>>>> + IORING_REGISTER_EVENTFD,
> >>>>> + IORING_UNREGISTER_EVENTFD,
> >>>>> + IORING_REGISTER_FILES_UPDATE,
> >>>>> + IORING_REGISTER_EVENTFD_ASYNC,
> >>>>> + IORING_REGISTER_PROBE,
> >>>>> + IORING_REGISTER_PERSONALITY,
> >>>>> + IORING_UNREGISTER_PERSONALITY,
> >>>>> +
> >>>>> + /* this goes last */
> >>>>> + IORING_REGISTER_LAST
> >>>>> +};
> >>>>
> >>>> It breaks userspace API. E.g.
> >>>>
> >>>> #ifdef IORING_REGISTER_BUFFERS
> >>>
> >>> It can, yes, but we have done that in the past. In this one, for
> >>
> >> Ok, if nobody on the userspace side cares, then better to do that
> >> sooner than later.
>
> I actually don't think it's a huge issue. Normally if applications
> do this, it's because they are using it and need it. Ala:
>
> #ifndef IORING_REGISTER_SOMETHING
> #define IORING_REGISTER_SOMETHING fooval
> #endif
>
> and that'll still work just fine, even if an identical enum is there.
>
Thank you both for the review!
Then if you agree, I'll leave this patch as it is by introducing the enum.
Stefano
next prev parent reply other threads:[~2020-07-17 8:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 12:48 [PATCH RFC v2 0/3] io_uring: add restrictions to support untrusted applications and guests Stefano Garzarella
2020-07-16 12:48 ` [PATCH RFC v2 1/3] io_uring: use an enumeration for io_uring_register(2) opcodes Stefano Garzarella
2020-07-16 20:16 ` Pavel Begunkov
2020-07-16 20:42 ` Jens Axboe
2020-07-16 20:47 ` Pavel Begunkov
2020-07-16 20:51 ` Jens Axboe
2020-07-16 21:20 ` Jens Axboe
2020-07-17 8:13 ` Stefano Garzarella [this message]
2020-07-16 12:48 ` [PATCH RFC v2 2/3] io_uring: add IOURING_REGISTER_RESTRICTIONS opcode Stefano Garzarella
2020-07-16 21:26 ` Jens Axboe
2020-07-17 8:55 ` Stefano Garzarella
2020-07-21 10:40 ` Stefano Garzarella
2020-07-21 17:11 ` Jens Axboe
2020-07-22 2:35 ` Daurnimator
2020-07-22 14:14 ` Stefano Garzarella
2020-07-22 14:29 ` Stefano Garzarella
2020-07-16 12:48 ` [PATCH RFC v2 3/3] io_uring: allow disabling rings during the creation Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox