From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840C0C433DF for ; Fri, 31 Jul 2020 06:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 645BC20829 for ; Fri, 31 Jul 2020 06:45:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="mJaTjZND" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731467AbgGaGpg (ORCPT ); Fri, 31 Jul 2020 02:45:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731400AbgGaGpf (ORCPT ); Fri, 31 Jul 2020 02:45:35 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96164C061574; Thu, 30 Jul 2020 23:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CiTqN18GYkJ0DtGuKf9NcwAeEt5aTI378Nv1sTLU35Y=; b=mJaTjZNDewq742QUSYLrjjRET4 xTTZk9J5FunTcSiatX6+U2iuryJoqeQm3I/nYZI7fgmIMjsODPXUxPr6CZAjOFHQEDy7lrzSJnVR5 3vo2tdegUmTszhEnmuqCsTq9hZ+oVD3yKUawaeMEhrcjWN/D7iizAwRTizMLVeEj9sgTT4J6VZfnM BxxyH4MG+MucQGMM0PnjgpkivxqXeVLMROK/5Bgd1s2ZPSbXkw6QdZEkkJmszF/GsBtzlbXU+Nmqm IsaNNWp4T5dgVye9hb9t/a4biSDzFlm443++WqbsMBC+z6Luj/2IOc7kgPuAS6CYb16Hm9j1aEs0s QNA/mihQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1OnG-0006tY-AI; Fri, 31 Jul 2020 06:45:26 +0000 Date: Fri, 31 Jul 2020 07:45:26 +0100 From: "hch@infradead.org" To: Damien Le Moal Cc: Kanchan Joshi , Jens Axboe , Pavel Begunkov , Kanchan Joshi , "viro@zeniv.linux.org.uk" , "bcrl@kvack.org" , Matthew Wilcox , "hch@infradead.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-aio@kvack.org" , "io-uring@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-api@vger.kernel.org" , SelvaKumar S , Nitesh Shetty , Javier Gonzalez Subject: Re: [PATCH v4 6/6] io_uring: add support for zone-append Message-ID: <20200731064526.GA25674@infradead.org> References: <80d27717-080a-1ced-50d5-a3a06cf06cd3@kernel.dk> <65a7e9a6-aede-31ce-705c-b7f94f079112@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Fri, Jul 31, 2020 at 06:42:10AM +0000, Damien Le Moal wrote: > > - We may not be able to use RWF_APPEND, and need exposing a new > > type/flag (RWF_INDIRECT_OFFSET etc.) user-space. Not sure if this > > sounds outrageous, but is it OK to have uring-only flag which can be > > combined with RWF_APPEND? > > Why ? Where is the problem ? O_APPEND/RWF_APPEND is currently meaningless for > raw block device accesses. We could certainly define a meaning for these in the > context of zoned block devices. We can't just add a meaning for O_APPEND on block devices now, as it was previously silently ignored. I also really don't think any of these semantics even fit the block device to start with. If you want to work on raw zones use zonefs, that's what is exists for.