From: Kees Cook <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Stefano Garzarella <[email protected]>,
Christian Brauner <[email protected]>,
Jann Horn <[email protected]>, Jeff Moyer <[email protected]>,
Linux FS Devel <[email protected]>,
Sargun Dhillon <[email protected]>,
Alexander Viro <[email protected]>,
Kernel Hardening <[email protected]>,
Stefan Hajnoczi <[email protected]>,
kernel list <[email protected]>,
Aleksa Sarai <[email protected]>,
io-uring <[email protected]>
Subject: Re: [PATCH v4 0/3] io_uring: add restrictions to support untrusted applications and guests
Date: Wed, 26 Aug 2020 12:40:24 -0700 [thread overview]
Message-ID: <202008261237.904C1E6@keescook> (raw)
In-Reply-To: <[email protected]>
On Wed, Aug 26, 2020 at 10:47:36AM -0600, Jens Axboe wrote:
> On 8/25/20 9:20 AM, Stefano Garzarella wrote:
> > Hi Jens,
> > this is a gentle ping.
> >
> > I'll respin, using memdup_user() for restriction registration.
> > I'd like to get some feedback to see if I should change anything else.
> >
> > Do you think it's in good shape?
>
> As far as I'm concerned, this is fine. But I want to make sure that Kees
> is happy with it, as he's the one that's been making noise on this front.
Oop! Sorry, I didn't realize this was blocked on me. Once I saw how
orthogonal io_uring was to "regular" process trees, I figured this
series didn't need seccomp input. (I mean, I am still concerned about
attack surface reduction, but that seems like a hard problem given
io_uring's design -- it is, however, totally covered by the LSMs, so I'm
satisfied from that perspective.)
I'll go review... thanks for the poke. :)
--
Kees Cook
next prev parent reply other threads:[~2020-08-26 19:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 15:32 [PATCH v4 0/3] io_uring: add restrictions to support untrusted applications and guests Stefano Garzarella
2020-08-13 15:32 ` [PATCH v4 1/3] io_uring: use an enumeration for io_uring_register(2) opcodes Stefano Garzarella
2020-08-26 19:40 ` Kees Cook
2020-08-26 19:43 ` Kees Cook
2020-08-26 19:52 ` Andreas Dilger
2020-08-27 7:11 ` Stefano Garzarella
2020-08-13 15:32 ` [PATCH v4 2/3] io_uring: add IOURING_REGISTER_RESTRICTIONS opcode Stefano Garzarella
2020-08-26 19:46 ` Kees Cook
2020-08-27 7:12 ` Stefano Garzarella
2020-08-13 15:32 ` [PATCH v4 3/3] io_uring: allow disabling rings during the creation Stefano Garzarella
2020-08-26 19:50 ` Kees Cook
2020-08-27 7:18 ` Stefano Garzarella
2020-08-27 15:04 ` Kees Cook
2020-08-25 15:20 ` [PATCH v4 0/3] io_uring: add restrictions to support untrusted applications and guests Stefano Garzarella
2020-08-26 16:47 ` Jens Axboe
2020-08-26 19:40 ` Kees Cook [this message]
2020-08-27 7:24 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008261237.904C1E6@keescook \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox