From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4D7C43466 for ; Mon, 21 Sep 2020 14:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4958A2085B for ; Mon, 21 Sep 2020 14:09:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YCvsJ8QA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726496AbgIUOJl (ORCPT ); Mon, 21 Sep 2020 10:09:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726456AbgIUOJk (ORCPT ); Mon, 21 Sep 2020 10:09:40 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DB4EC061755; Mon, 21 Sep 2020 07:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5z+nT9DLNYpnZdX2p/A/Uj6Iw3m/Dm3X+A2sRHM2Sw8=; b=YCvsJ8QAivd0kiBxMhH8zI6ld2 dxecllp2hObiTjswAkaOEPy4nIaOSt7eKX1MkZBSl/byZKc4E803ZZH5062ZYKnW+V73XhKHdxeK4 tjrWzyJO7lVKQb+vA9iKuvghqZX912IlsuF0xxclpn7MYfFcvM47OPWuBpfbE+GNzhugw18XimuNl 1CoNaLxpAHeH3+AKoM+75id0MvySxR2b5SDaenlEQH/kKBQZ8m3iRuHufHLZwGg4XPS3BqTDcpLjA p+N3BlfPxibCFwCPNRyEUWdqL+XjU96GIKxa6yTX0zjTmhY6TvsQCtPp3j3qczEIsScdy8LSoMEL/ N9P5tkkA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKMVb-0006QJ-O3; Mon, 21 Sep 2020 14:09:35 +0000 Date: Mon, 21 Sep 2020 15:09:35 +0100 From: Christoph Hellwig To: David Laight Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "io-uring@vger.kernel.org" , Jens Axboe , "David S. Miller" , Al Viro , linux-fsdevel Subject: Re: [PATCH 1/9 next] mm:process_vm_access Call import_iovec() instead of rw_copy_check_uvector() Message-ID: <20200921140935.GA24515@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Tue, Sep 15, 2020 at 02:55:08PM +0000, David Laight wrote: > > This is the only direct call of rw_copy_check_uvector(). > Removing it lets rw_copy_check_uvector() be inlined into > import_iovec() and the horrid calling conventions fixed. This looks sensible, but as-is will create a warning when actually this code. This is the variant I picked up as a prep patch for the compat iovec handling, which passes the relevant LTP tests: http://git.infradead.org/users/hch/misc.git/commitdiff/9e3cf5d0f13572310354bf6c62e1feb9fb232266