public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] Fix compilation with iso C standard
@ 2020-10-28  3:18 Simon Zeni
  2020-10-28 22:31 ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Simon Zeni @ 2020-10-28  3:18 UTC (permalink / raw)
  To: io-uring; +Cc: Simon Zeni

The whole repo can now be built with iso C standard (c89, c99 and c11)

Signed-off-by: Simon Zeni <[email protected]>
---

References to the compiler extension `typeof` have been changed to
`__typeof__` for portability. See [GCC's documentation][1] about
`typeof`.

I've added the definition `_POSIX_C_SOURCE` in the source files that are
using functions not defined in by the POSIX standard, fixing a few
occurences of `sigset_t` not being defined.

I've also added the definition `_BSD_SOURCE` in `setup.c` and
`syscall.c` for respectively the `madvise` function (I know that
`posix_madvise` exists, but there is not equivalent for
`MADV_DONTFORK`), and `syscall`.

Cheers,

Simon

[1]: https://gcc.gnu.org/onlinedocs/gcc/Typeof.html

 src/include/liburing/barrier.h | 8 ++++----
 src/queue.c                    | 2 ++
 src/register.c                 | 2 ++
 src/setup.c                    | 3 +++
 src/syscall.c                  | 2 ++
 5 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/include/liburing/barrier.h b/src/include/liburing/barrier.h
index a4a59fb..89ac682 100644
--- a/src/include/liburing/barrier.h
+++ b/src/include/liburing/barrier.h
@@ -56,17 +56,17 @@ static inline T io_uring_smp_load_acquire(const T *p)
 #include <stdatomic.h>

 #define IO_URING_WRITE_ONCE(var, val)				\
-	atomic_store_explicit((_Atomic typeof(var) *)&(var),	\
+	atomic_store_explicit((_Atomic __typeof__(var) *)&(var),	\
 			      (val), memory_order_relaxed)
 #define IO_URING_READ_ONCE(var)					\
-	atomic_load_explicit((_Atomic typeof(var) *)&(var),	\
+	atomic_load_explicit((_Atomic __typeof__(var) *)&(var),	\
 			     memory_order_relaxed)

 #define io_uring_smp_store_release(p, v)			\
-	atomic_store_explicit((_Atomic typeof(*(p)) *)(p), (v), \
+	atomic_store_explicit((_Atomic __typeof__(*(p)) *)(p), (v), \
 			      memory_order_release)
 #define io_uring_smp_load_acquire(p)				\
-	atomic_load_explicit((_Atomic typeof(*(p)) *)(p),	\
+	atomic_load_explicit((_Atomic __typeof__(*(p)) *)(p),	\
 			     memory_order_acquire)
 #endif

diff --git a/src/queue.c b/src/queue.c
index 24fde2d..053d430 100644
--- a/src/queue.c
+++ b/src/queue.c
@@ -1,4 +1,6 @@
 /* SPDX-License-Identifier: MIT */
+#define _POSIX_C_SOURCE 200112L
+
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <sys/mman.h>
diff --git a/src/register.c b/src/register.c
index f3787c0..994aaff 100644
--- a/src/register.c
+++ b/src/register.c
@@ -1,4 +1,6 @@
 /* SPDX-License-Identifier: MIT */
+#define _POSIX_C_SOURCE 200112L
+
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <sys/mman.h>
diff --git a/src/setup.c b/src/setup.c
index 8e14085..ce2ff4f 100644
--- a/src/setup.c
+++ b/src/setup.c
@@ -1,4 +1,6 @@
 /* SPDX-License-Identifier: MIT */
+#define _BSD_SOURCE
+
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <sys/mman.h>
@@ -6,6 +8,7 @@
 #include <errno.h>
 #include <string.h>
 #include <stdlib.h>
+#include <signal.h>

 #include "liburing/compat.h"
 #include "liburing/io_uring.h"
diff --git a/src/syscall.c b/src/syscall.c
index 598b531..3f9aa9f 100644
--- a/src/syscall.c
+++ b/src/syscall.c
@@ -1,4 +1,6 @@
 /* SPDX-License-Identifier: MIT */
+#define _BSD_SOURCE
+
 /*
  * Will go away once libc support is there
  */
--
2.29.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-29  1:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-28  3:18 [PATCH] Fix compilation with iso C standard Simon Zeni
2020-10-28 22:31 ` Jens Axboe
2020-10-29  1:00   ` Simon Zeni
2020-10-29  1:05     ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox