From: Christian Brauner <christian.brauner@ubuntu.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH] io_uring: don't assume mm is constant across submits
Date: Wed, 30 Dec 2020 15:17:53 +0100 [thread overview]
Message-ID: <20201230141753.hakwbf6c6xw2ohts@wittgenstein> (raw)
In-Reply-To: <7224e4df-50e9-ffd1-5453-391802fcded7@kernel.dk>
On Tue, Dec 29, 2020 at 10:53:21AM -0700, Jens Axboe wrote:
> If we COW the identity, we assume that ->mm never changes. But this
> isn't true of multiple processes end up sharing the ring. Hence treat
> id->mm like like any other process compontent when it comes to the
> identity mapping.
>
> Reported-by: Christian Brauner <christian.brauner@ubuntu.com>:
> Tested-by: Christian Brauner <christian.brauner@ubuntu.com>:
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> ---
Thanks for fixing this! Fwiw, tested again just now.
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
prev parent reply other threads:[~2020-12-30 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 17:53 [PATCH] io_uring: don't assume mm is constant across submits Jens Axboe
2020-12-30 14:17 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230141753.hakwbf6c6xw2ohts@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox