From: Andres Freund <[email protected]>
To: Lennert Buytenhek <[email protected]>
Cc: Jens Axboe <[email protected]>,
[email protected], [email protected],
[email protected], [email protected]
Subject: Re: [RFC PATCH] io_uring: add support for IORING_OP_GETDENTS64
Date: Sat, 23 Jan 2021 15:56:20 -0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Hi,
On 2021-01-23 15:50:55 -0800, Andres Freund wrote:
> It's also not clear to me that right now you'd necessarily get correct
> results if multiple IORING_OP_GETDENTS64 for the same fd get processed
> in different workers. Looking at iterate_dir(), it looks to me that the
> locking around the file position would end up being insufficient on
> filesystems that implement iterate_shared?
> [...]
> As there's only a shared lock, seems like both would end up with the
> same ctx->pos and end up updating f_pos to the same offset (assuming the
> same count).
>
> Am I missing something?
A minimal and brute force approach to this would be to use
io_op_def.hash_reg_file, but brrr, that doesn't seem like a great way
forward.
Greetings,
Andres Freund
next prev parent reply other threads:[~2021-01-23 23:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 11:41 [RFC PATCH] io_uring: add support for IORING_OP_GETDENTS64 Lennert Buytenhek
2021-01-23 17:37 ` Jens Axboe
2021-01-23 18:16 ` Lennert Buytenhek
2021-01-23 18:22 ` Jens Axboe
2021-01-23 23:27 ` Matthew Wilcox
2021-01-23 23:33 ` Jens Axboe
2021-01-28 22:30 ` Lennert Buytenhek
2021-01-23 23:50 ` Andres Freund
2021-01-23 23:56 ` Andres Freund [this message]
2021-01-24 1:59 ` Al Viro
2021-01-24 2:17 ` Andres Freund
2021-01-24 22:21 ` David Laight
2021-01-28 23:07 ` Lennert Buytenhek
2021-01-29 5:37 ` Lennert Buytenhek
2021-01-29 9:41 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox