From: Al Viro <[email protected]>
To: Andres Freund <[email protected]>
Cc: Lennert Buytenhek <[email protected]>,
Jens Axboe <[email protected]>,
[email protected], [email protected],
[email protected], [email protected]
Subject: Re: [RFC PATCH] io_uring: add support for IORING_OP_GETDENTS64
Date: Sun, 24 Jan 2021 01:59:05 +0000 [thread overview]
Message-ID: <20210124015905.GH740243@zeniv-ca> (raw)
In-Reply-To: <[email protected]>
On Sat, Jan 23, 2021 at 03:50:55PM -0800, Andres Freund wrote:
> As there's only a shared lock, seems like both would end up with the
> same ctx->pos and end up updating f_pos to the same offset (assuming the
> same count).
>
> Am I missing something?
This:
f = fdget_pos(fd);
if (!f.file)
return -EBADF;
in the callers. Protection of struct file contents belongs to struct file,
*not* struct inode. Specifically, file->f_pos_lock. *IF* struct file
in question happens to be shared and the file is a regular or directory
(sockets don't need any exclusion on read(2), etc.)
next prev parent reply other threads:[~2021-01-24 2:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 11:41 [RFC PATCH] io_uring: add support for IORING_OP_GETDENTS64 Lennert Buytenhek
2021-01-23 17:37 ` Jens Axboe
2021-01-23 18:16 ` Lennert Buytenhek
2021-01-23 18:22 ` Jens Axboe
2021-01-23 23:27 ` Matthew Wilcox
2021-01-23 23:33 ` Jens Axboe
2021-01-28 22:30 ` Lennert Buytenhek
2021-01-23 23:50 ` Andres Freund
2021-01-23 23:56 ` Andres Freund
2021-01-24 1:59 ` Al Viro [this message]
2021-01-24 2:17 ` Andres Freund
2021-01-24 22:21 ` David Laight
2021-01-28 23:07 ` Lennert Buytenhek
2021-01-29 5:37 ` Lennert Buytenhek
2021-01-29 9:41 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124015905.GH740243@zeniv-ca \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox