From: Colin King <[email protected]>
To: Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected]
Cc: [email protected], [email protected]
Subject: [PATCH][next] io_uring: remove redundant initialization of variable ret
Date: Wed, 10 Feb 2021 20:00:07 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
From: Colin Ian King <[email protected]>
The variable ret is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Fixes: b63534c41e20 ("io_uring: re-issue block requests that failed because of resources")
Signed-off-by: Colin Ian King <[email protected]>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 909b3169d74e..eff58a967822 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2785,7 +2785,7 @@ static void io_complete_rw_common(struct kiocb *kiocb, long res,
static bool io_resubmit_prep(struct io_kiocb *req)
{
struct iovec inline_vecs[UIO_FASTIOV], *iovec = inline_vecs;
- int rw, ret = -ECANCELED;
+ int rw, ret;
struct iov_iter iter;
/* already prepared */
--
2.30.0
next reply other threads:[~2021-02-10 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 20:00 Colin King [this message]
2021-02-10 20:05 ` [PATCH][next] io_uring: remove redundant initialization of variable ret Chaitanya Kulkarni
2021-02-10 20:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox