public inbox for [email protected]
 help / color / mirror / Atom feed
From: Andres Freund <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected]
Subject: io_uring_enter() returns EAGAIN after child exit in 5.12
Date: Tue, 23 Feb 2021 19:25:14 -0800	[thread overview]
Message-ID: <[email protected]> (raw)

Hi,

commit 41be53e94fb04cc69fdf2f524c2a05d8069e047b (HEAD, refs/bisect/bad)
Author: Jens Axboe <[email protected]>
Date:   2021-02-13 09:11:04 -0700

    io_uring: kill cached requests from exiting task closing the ring

    Be nice and prune these upfront, in case the ring is being shared and
    one of the tasks is going away. This is a bit more important now that
    we account the allocations.

    Signed-off-by: Jens Axboe <[email protected]>


causes EAGAIN to be returned by io_uring_enter() after a child
exits. The existing liburing test across-fork.c repros the issue after
applying the patch below.

Retrying the submission twice seems to make it succeed most of the
time...

Greetings,

Andres Freund

diff --git a/test/across-fork.c b/test/across-fork.c
index 14ee93a..2b19f39 100644
--- a/test/across-fork.c
+++ b/test/across-fork.c
@@ -220,6 +220,13 @@ int main(int argc, char *argv[])
                if (wait_cqe(&shmem->ring, "p cqe 2"))
                        goto errcleanup;
 
+               /* check that IO still works after the child exited */
+               if (submit_write(&shmem->ring, shared_fd, "parent: after child exit\n", 0))
+                       goto errcleanup;
+
+               if (wait_cqe(&shmem->ring, "p cqe 3"))
+                       goto errcleanup;
+
                break;
        }
        case 0: {
@@ -260,7 +267,8 @@ int main(int argc, char *argv[])
        if (verify_file(tmpdir, "shared",
                         "before fork: write shared fd\n"
                         "parent: write shared fd\n"
-                        "child: write shared fd\n") ||
+                        "child: write shared fd\n"
+                        "parent: after child exit\n") ||
            verify_file(tmpdir, "parent1", "parent: write parent fd 1\n") ||
            verify_file(tmpdir, "parent2", "parent: write parent fd 2\n") ||
            verify_file(tmpdir, "child", "child: write child fd\n"))

             reply	other threads:[~2021-02-24  3:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  3:25 Andres Freund [this message]
2021-02-24  3:35 ` io_uring_enter() returns EAGAIN after child exit in 5.12 Jens Axboe
2021-02-24  4:31   ` Andres Freund
2021-02-24  4:33     ` Jens Axboe
2021-02-24  4:54       ` Andres Freund
2021-02-24 16:24         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox