public inbox for [email protected]
 help / color / mirror / Atom feed
From: Andres Freund <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected]
Subject: Re: io_uring_enter() returns EAGAIN after child exit in 5.12
Date: Tue, 23 Feb 2021 20:31:49 -0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Hi,

On 2021-02-23 20:35:09 -0700, Jens Axboe wrote:
> On 2/23/21 8:25 PM, Andres Freund wrote:
> > Hi,
> > 
> > commit 41be53e94fb04cc69fdf2f524c2a05d8069e047b (HEAD, refs/bisect/bad)
> > Author: Jens Axboe <[email protected]>
> > Date:   2021-02-13 09:11:04 -0700
> > 
> >     io_uring: kill cached requests from exiting task closing the ring
> > 
> >     Be nice and prune these upfront, in case the ring is being shared and
> >     one of the tasks is going away. This is a bit more important now that
> >     we account the allocations.
> > 
> >     Signed-off-by: Jens Axboe <[email protected]>
> > 
> > 
> > causes EAGAIN to be returned by io_uring_enter() after a child
> > exits. The existing liburing test across-fork.c repros the issue after
> > applying the patch below.
> > 
> > Retrying the submission twice seems to make it succeed most of the
> > time...
> 
> Oh that's funky, I'll take a look.
 
It was fixed in

commit 8e5c66c485a8af3f39a8b0358e9e09f002016d92
Author: Pavel Begunkov <[email protected]>
Date:   2021-02-22 11:45:55 +0000

    io_uring: clear request count when freeing caches


Jens, seems like it'd make sense to apply the test case upthread into
the liburing repo. Do you want me to open a PR?

Greetings,

Andres Freund

  reply	other threads:[~2021-02-24  4:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  3:25 io_uring_enter() returns EAGAIN after child exit in 5.12 Andres Freund
2021-02-24  3:35 ` Jens Axboe
2021-02-24  4:31   ` Andres Freund [this message]
2021-02-24  4:33     ` Jens Axboe
2021-02-24  4:54       ` Andres Freund
2021-02-24 16:24         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox