From: Oleg Nesterov <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected]
Subject: Re: [PATCH 2/8] kernel: unmask SIGSTOP for IO threads
Date: Fri, 26 Mar 2021 14:48:41 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Jens, sorry, I got lost :/
On 03/25, Jens Axboe wrote:
>
> With IO threads accepting signals, including SIGSTOP,
where can I find this change? Looks like I wasn't cc'ed...
> unmask the
> SIGSTOP signal from the default blocked mask.
>
> Signed-off-by: Jens Axboe <[email protected]>
> ---
> kernel/fork.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index d3171e8e88e5..d5a40552910f 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2435,7 +2435,7 @@ struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
> tsk = copy_process(NULL, 0, node, &args);
> if (!IS_ERR(tsk)) {
> sigfillset(&tsk->blocked);
> - sigdelsetmask(&tsk->blocked, sigmask(SIGKILL));
> + sigdelsetmask(&tsk->blocked, sigmask(SIGKILL)|sigmask(SIGSTOP));
siginitsetinv(blocked, sigmask(SIGKILL)|sigmask(SIGSTOP)) but this is minor.
To remind, either way this is racy and can't really help.
And if "IO threads accepting signals" then I don't understand why. Sorry,
I must have missed something.
Oleg.
next prev parent reply other threads:[~2021-03-26 13:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 0:39 [PATCH 0/6] Allow signals for IO threads Jens Axboe
2021-03-26 0:39 ` [PATCH 1/8] io_uring: handle signals for IO threads like a normal thread Jens Axboe
2021-03-26 0:39 ` [PATCH 2/8] kernel: unmask SIGSTOP for IO threads Jens Axboe
2021-03-26 13:48 ` Oleg Nesterov [this message]
2021-03-26 15:01 ` Jens Axboe
2021-03-26 15:23 ` Stefan Metzmacher
2021-03-26 15:29 ` Jens Axboe
2021-03-26 18:01 ` Stefan Metzmacher
2021-03-26 18:59 ` Jens Axboe
2021-04-01 14:53 ` Stefan Metzmacher
2021-03-26 0:39 ` [PATCH 3/8] Revert "signal: don't allow sending any signals to PF_IO_WORKER threads" Jens Axboe
2021-03-26 0:39 ` [PATCH 4/8] Revert "kernel: treat PF_IO_WORKER like PF_KTHREAD for ptrace/signals" Jens Axboe
2021-03-26 0:39 ` [PATCH 5/8] Revert "kernel: freezer should treat PF_IO_WORKER like PF_KTHREAD for freezing" Jens Axboe
2021-03-26 0:39 ` [PATCH 6/8] Revert "signal: don't allow STOP on PF_IO_WORKER threads" Jens Axboe
[not found] ` <[email protected]>
2021-03-26 12:56 ` [PATCH 0/6] Allow signals for IO threads Jens Axboe
2021-03-26 13:31 ` Stefan Metzmacher
2021-03-26 13:54 ` Jens Axboe
2021-03-26 13:59 ` Jens Axboe
2021-03-26 14:38 ` Jens Axboe
2021-03-26 14:43 ` Stefan Metzmacher
2021-03-26 14:45 ` Stefan Metzmacher
2021-03-26 14:53 ` Jens Axboe
2021-03-26 14:55 ` Jens Axboe
2021-03-26 15:08 ` Stefan Metzmacher
2021-03-26 15:10 ` Jens Axboe
2021-03-26 15:11 ` Stefan Metzmacher
2021-03-26 15:12 ` Jens Axboe
2021-03-26 15:04 ` Stefan Metzmacher
2021-03-26 15:09 ` Jens Axboe
2021-03-26 14:50 ` Jens Axboe
2021-03-27 1:46 ` Stefan Metzmacher
2021-03-27 16:41 ` Jens Axboe
2021-04-01 14:58 ` Stefan Metzmacher
2021-04-01 15:39 ` Linus Torvalds
2021-04-01 16:00 ` Stefan Metzmacher
2021-04-01 16:24 ` Linus Torvalds
2021-04-03 0:48 ` Stefan Metzmacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox