From: Stefano Garzarella <[email protected]>
To: Stefan Hajnoczi <[email protected]>
Cc: [email protected], Pavel Begunkov <[email protected]>,
"H.J. Lu" <[email protected]>,
[email protected], Jens Axboe <[email protected]>,
[email protected]
Subject: Re: [PATCH liburing] examples/ucontext-cp.c: cope with variable SIGSTKSZ
Date: Thu, 22 Apr 2021 16:22:45 +0200 [thread overview]
Message-ID: <20210422142245.evlxjvfw3emh7ivw@steredhat> (raw)
In-Reply-To: <[email protected]>
+Cc: [email protected]
+Cc: Pavel Begunkov <[email protected]>
Original message:
https://www.spinics.net/lists/linux-block/msg67077.html
On Thu, Apr 22, 2021 at 10:59:42AM +0100, Stefan Hajnoczi wrote:
>On Mon, Apr 19, 2021 at 11:38:07AM -0700, H.J. Lu wrote:
>> On Mon, Apr 19, 2021 at 7:35 AM Stefan Hajnoczi <[email protected]> wrote:
>> >
>> > On Tue, Apr 13, 2021 at 04:03:19PM +0100, Stefan Hajnoczi wrote:
>> > > The size of C arrays at file scope must be constant. The following
>> > > compiler error occurs with recent upstream glibc (2.33.9000):
>> > >
>> > > CC ucontext-cp
>> > > ucontext-cp.c:31:23: error: variably modified ‘stack_buf’ at file scope
>> > > 31 | unsigned char stack_buf[SIGSTKSZ];
>> > > | ^~~~~~~~~
>> > > make[1]: *** [Makefile:26: ucontext-cp] Error 1
>> > >
>> > > The following glibc commit changed SIGSTKSZ from a constant value to a
>> > > variable:
>> > >
>> > > commit 6c57d320484988e87e446e2e60ce42816bf51d53
>> > > Author: H.J. Lu <[email protected]>
>> > > Date: Mon Feb 1 11:00:38 2021 -0800
>> > >
>> > > sysconf: Add _SC_MINSIGSTKSZ/_SC_SIGSTKSZ [BZ #20305]
>> > > ...
>> > > +# define SIGSTKSZ sysconf (_SC_SIGSTKSZ)
>> > >
>> > > Allocate the stack buffer explicitly to avoid declaring an array at file
>> > > scope.
>> > >
>> > > Cc: H.J. Lu <[email protected]>
>> > > Signed-off-by: Stefan Hajnoczi <[email protected]>
>> > > ---
>> > > Perhaps the glibc change needs to be revised before releasing glibc 2.34
>> > > since it might break applications. That's up to the glibc folks. It
>> > > doesn't hurt for liburing to take a safer approach that copes with the
>> > > SIGSTKSZ change in any case.
>> >
>> > glibc folks, please take a look. The commit referenced above broke
>> > compilation of liburing's tests. It's possible that applications will
>> > hit similar issues. Can you check whether the SIGSTKSZ change needs to
>> > be reverted/fixed before releasing glibc 2.34?
>> >
>>
>> It won't be changed for glibc 2.34.
>
>Thanks for the response, H.J. and Paul.
>
>In that case liburing needs this patch.
>
I think so:
Reviewed-by: Stefano Garzarella <[email protected]>
next parent reply other threads:[~2021-04-22 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[email protected]>
[not found] ` <[email protected]>
[not found] ` <CAMe9rOpK08CJ5TdQ1fZJ2sGUVjHqoTHS2kT8EzDEejuodu8Ksg@mail.gmail.com>
[not found] ` <[email protected]>
2021-04-22 14:22 ` Stefano Garzarella [this message]
2021-04-23 14:13 ` [PATCH liburing] examples/ucontext-cp.c: cope with variable SIGSTKSZ Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422142245.evlxjvfw3emh7ivw@steredhat \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox