From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C481C11F66 for ; Tue, 29 Jun 2021 13:06:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83CDD61DC4 for ; Tue, 29 Jun 2021 13:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233482AbhF2NJZ (ORCPT ); Tue, 29 Jun 2021 09:09:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:49536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233862AbhF2NJF (ORCPT ); Tue, 29 Jun 2021 09:09:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7DF7861DC0; Tue, 29 Jun 2021 13:06:36 +0000 (UTC) Date: Tue, 29 Jun 2021 15:06:33 +0200 From: Christian Brauner To: Dmitry Kadashev Cc: Jens Axboe , Alexander Viro , Pavel Begunkov , linux-fsdevel@vger.kernel.org, io-uring Subject: Re: [PATCH v5 00/10] io_uring: add mkdir, [sym]linkat and mknodat support Message-ID: <20210629130633.pqxg7otr542wrj2g@wittgenstein> References: <20210603051836.2614535-1-dkadashev@gmail.com> <2c4d5933-965e-29b5-0c76-3f2e5f518fe8@kernel.dk> <20210622081240.c7tzq7e7gt3y3u7j@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Tue, Jun 22, 2021 at 03:34:37PM +0700, Dmitry Kadashev wrote: > On Tue, Jun 22, 2021 at 3:12 PM Christian Brauner > wrote: > > > > On Mon, Jun 21, 2021 at 09:21:23AM -0600, Jens Axboe wrote: > > > On 6/18/21 10:10 AM, Jens Axboe wrote: > > > > On 6/18/21 12:24 AM, Dmitry Kadashev wrote: > > > >> On Thu, Jun 3, 2021 at 12:18 PM Dmitry Kadashev wrote: > > > >>> > > > >>> This started out as an attempt to add mkdirat support to io_uring which > > > >>> is heavily based on renameat() / unlinkat() support. > > > >>> > > > >>> During the review process more operations were added (linkat, symlinkat, > > > >>> mknodat) mainly to keep things uniform internally (in namei.c), and > > > >>> with things changed in namei.c adding support for these operations to > > > >>> io_uring is trivial, so that was done too. See > > > >>> https://lore.kernel.org/io-uring/20210514145259.wtl4xcsp52woi6ab@wittgenstein/ > > > >> > > > >> Ping. Jens, are we waiting for the audit change to be merged before this > > > >> can go in? > > > > > > > > Not necessarily, as that should go in for 5.14 anyway. > > > > > > > > Al, are you OK with the generic changes? > > > > > > I have tentatively queued this up. > > > > Hey Dmitry, > > hey Jens, > > > > The additional op codes and suggested rework is partially on me. So I > > should share the blame in case this gets a NAK: > > > > Acked-by: Christian Brauner > > Hi Christian, > > Thank you very much for your help with this! Just wanted to say that you > were quite supportive and really helped me a lot. Hey Dmitry, Thank you for saying that! Much appreciated. Thanks for working on this! Christian