From: "Matthew Wilcox (Oracle)" <[email protected]>
To: Jens Axboe <[email protected]>
Cc: "Matthew Wilcox (Oracle)" <[email protected]>,
[email protected], [email protected],
[email protected], [email protected]
Subject: [PATCH 0/2] Close a hole where IOCB_NOWAIT reads could sleep
Date: Sun, 11 Jul 2021 16:09:25 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
I noticed a theoretical case where an IOCB_NOWAIT read could sleep:
filemap_get_pages
filemap_get_read_batch
page_cache_sync_readahead
page_cache_sync_ra
ondemand_readahead
do_page_cache_ra
page_cache_ra_unbounded
gfp_t gfp_mask = readahead_gfp_mask(mapping);
memalloc_nofs_save()
__page_cache_alloc(gfp_mask);
We're in a nofs context, so we're not going to start new IO, but we might
wait for writeback to complete. We generally don't want to sleep for IO,
particularly not for IO that isn't related to us.
Jens, can you run this through your test rig and see if it makes any
practical difference?
Matthew Wilcox (Oracle) (2):
mm/readahead: Add gfp_flags to ractl
mm/filemap: Prevent waiting for memory for NOWAIT reads
include/linux/pagemap.h | 3 +++
mm/filemap.c | 31 +++++++++++++++++++------------
mm/readahead.c | 16 ++++++++--------
3 files changed, 30 insertions(+), 20 deletions(-)
--
2.30.2
next reply other threads:[~2021-07-11 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 15:09 Matthew Wilcox (Oracle) [this message]
2021-07-11 15:09 ` [PATCH 1/2] mm/readahead: Add gfp_flags to ractl Matthew Wilcox (Oracle)
2021-07-12 11:34 ` Christoph Hellwig
2021-07-12 14:37 ` Matthew Wilcox
2021-07-11 15:09 ` [PATCH 2/2] mm/filemap: Prevent waiting for memory for NOWAIT reads Matthew Wilcox (Oracle)
2021-07-12 1:44 ` [PATCH 0/2] Close a hole where IOCB_NOWAIT reads could sleep Jens Axboe
2021-07-24 18:22 ` Matthew Wilcox
2021-07-24 19:46 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox