From: Jens Axboe <[email protected]>
To: [email protected]
Cc: [email protected], Jens Axboe <[email protected]>
Subject: [PATCH 4/4] block: enable use of bio allocation cache
Date: Mon, 9 Aug 2021 15:24:01 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
If a kiocb is marked as being valid for bio caching, then use that to
allocate a (and free) new bio if possible.
Signed-off-by: Jens Axboe <[email protected]>
---
fs/block_dev.c | 30 ++++++++++++++++++++++++++----
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 9ef4f1fc2cb0..36a3d53326c0 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -327,6 +327,14 @@ static int blkdev_iopoll(struct kiocb *kiocb, bool wait)
return blk_poll(q, READ_ONCE(kiocb->ki_cookie), wait);
}
+static void dio_bio_put(struct blkdev_dio *dio)
+{
+ if (!dio->is_sync && (dio->iocb->ki_flags & IOCB_ALLOC_CACHE))
+ bio_cache_put(&dio->bio);
+ else
+ bio_put(&dio->bio);
+}
+
static void blkdev_bio_end_io(struct bio *bio)
{
struct blkdev_dio *dio = bio->bi_private;
@@ -362,7 +370,7 @@ static void blkdev_bio_end_io(struct bio *bio)
bio_check_pages_dirty(bio);
} else {
bio_release_pages(bio, false);
- bio_put(bio);
+ dio_bio_put(dio);
}
}
@@ -385,7 +393,14 @@ static ssize_t __blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
(bdev_logical_block_size(bdev) - 1))
return -EINVAL;
- bio = bio_alloc_bioset(GFP_KERNEL, nr_pages, &blkdev_dio_pool);
+ bio = NULL;
+ if (iocb->ki_flags & IOCB_ALLOC_CACHE) {
+ bio = bio_cache_get(GFP_KERNEL, nr_pages, &blkdev_dio_pool);
+ if (!bio)
+ iocb->ki_flags &= ~IOCB_ALLOC_CACHE;
+ }
+ if (!bio)
+ bio = bio_alloc_bioset(GFP_KERNEL, nr_pages, &blkdev_dio_pool);
dio = container_of(bio, struct blkdev_dio, bio);
dio->is_sync = is_sync = is_sync_kiocb(iocb);
@@ -467,7 +482,14 @@ static ssize_t __blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
}
submit_bio(bio);
- bio = bio_alloc(GFP_KERNEL, nr_pages);
+ bio = NULL;
+ if (iocb->ki_flags & IOCB_ALLOC_CACHE) {
+ bio = bio_cache_get(GFP_KERNEL, nr_pages, &fs_bio_set);
+ if (!bio)
+ iocb->ki_flags &= ~IOCB_ALLOC_CACHE;
+ }
+ if (!bio)
+ bio = bio_alloc(GFP_KERNEL, nr_pages);
}
if (!is_poll)
@@ -492,7 +514,7 @@ static ssize_t __blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
if (likely(!ret))
ret = dio->size;
- bio_put(&dio->bio);
+ dio_bio_put(dio);
return ret;
}
--
2.32.0
next prev parent reply other threads:[~2021-08-09 21:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 21:23 [PATCHSET 0/4] Enable bio recycling for polled IO Jens Axboe
2021-08-09 21:23 ` [PATCH 1/4] bio: add allocation cache abstraction Jens Axboe
2021-08-10 13:15 ` Ming Lei
2021-08-10 13:53 ` Jens Axboe
2021-08-10 14:24 ` Jens Axboe
2021-08-10 14:48 ` Jens Axboe
2021-08-10 15:35 ` Jens Axboe
2021-08-10 15:54 ` Kanchan Joshi
2021-08-10 15:58 ` Jens Axboe
2021-08-09 21:23 ` [PATCH 2/4] fs: add bio alloc cache kiocb flag Jens Axboe
2021-08-09 21:24 ` [PATCH 3/4] io_uring: wire up bio allocation cache Jens Axboe
2021-08-10 12:25 ` Kanchan Joshi
2021-08-10 13:50 ` Jens Axboe
2021-08-09 21:24 ` Jens Axboe [this message]
2021-08-10 12:39 ` [PATCH 4/4] block: enable use of " Kanchan Joshi
2021-08-10 13:56 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox