From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0649EC433EF for ; Sun, 12 Sep 2021 22:24:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1EAD61039 for ; Sun, 12 Sep 2021 22:24:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236620AbhILWZv (ORCPT ); Sun, 12 Sep 2021 18:25:51 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:48690 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235898AbhILWZv (ORCPT ); Sun, 12 Sep 2021 18:25:51 -0400 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id E567972C8B1; Mon, 13 Sep 2021 01:24:34 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id D64787CF786; Mon, 13 Sep 2021 01:24:34 +0300 (MSK) Date: Mon, 13 Sep 2021 01:24:34 +0300 From: "Dmitry V. Levin" To: Jens Axboe Cc: Eugene Syromiatnikov , Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH] io-wq: expose IO_WQ_ACCT_* enumeration items to UAPI Message-ID: <20210912222434.GD18053@altlinux.org> References: <20210912122411.GA27679@asgard.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Sun, Sep 12, 2021 at 12:29:41PM -0600, Jens Axboe wrote: > On 9/12/21 6:24 AM, Eugene Syromiatnikov wrote: > > These are used to index aargument of IORING_REGISTER_IOWQ_MAX_WORKERS > > io_uring_register command, so they are to be exposed in UAPI. > > Not sure that's necessary, as it's really just a boolean values - is > the worker type bounded or not. That said, not against making it > available for userspace, but definitely not IO_WQ_ACCT_NR. It > should probably just go in liburing, I guess. If IO_WQ_ACCT_* were just boolean values, no enum would have been introduced in the first place. What's the benefit of hiding the API in the implementation, or burying it inside liburing? -- ldv