public inbox for [email protected]
 help / color / mirror / Atom feed
From: Eugene Syromiatnikov <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Pavel Begunkov <[email protected]>,
	[email protected], [email protected],
	"Dmitry V. Levin" <[email protected]>,
	[email protected]
Subject: Re: [PATCH v2] io-wq: expose IO_WQ_ACCT_* enumeration items to UAPI
Date: Mon, 13 Sep 2021 17:52:43 +0200	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Mon, Sep 13, 2021 at 07:28:11AM -0600, Jens Axboe wrote:
> This is really the same thing as before, just the names have changed.
> What I suggested was keeping the enum in io_uring, then just adding
> 
> enum {
> 	IO_WQ_BOUND,
> 	IO_WQ_UNBOUND,
> };
> 
> to uapi header. The ACCT stuff is io-wq specific too, that kind of naming
> shouldn't be propagated to userspace.

My apologies, I've overlooked the fact that the proposed names
are different.  Updated and resent[1].

[1] https://lore.kernel.org/lkml/[email protected]/

> A BUILD_BUG_ON() could be added for them being different, but honestly
> I don't think that's worth it.


      reply	other threads:[~2021-09-13 15:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 10:41 [PATCH v2] io-wq: expose IO_WQ_ACCT_* enumeration items to UAPI Eugene Syromiatnikov
2021-09-13 13:28 ` Jens Axboe
2021-09-13 15:52   ` Eugene Syromiatnikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox