From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8802AC433FE for ; Mon, 13 Sep 2021 15:53:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 667FC60FC1 for ; Mon, 13 Sep 2021 15:53:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238348AbhIMPyR (ORCPT ); Mon, 13 Sep 2021 11:54:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54137 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245530AbhIMPyJ (ORCPT ); Mon, 13 Sep 2021 11:54:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631548373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k3ULkNN3/XfJylBmZ/HItDZv9Uxt7R1OIeLedwQKthY=; b=CNEFFcQkHYc6Mcaao6Qdzt1GCO+gFeJtLPFwQnPtGZInzBRWs+4a6B3M/4irKgpyowkLyP eKG7CJXLwW7hG2pxNMLRMS1m7aEjh846kg0o1yyXXUJ3RZGuD3iJ7WdkDn43IkIk46G7TS oTVCtVtn7pBVMKcfEGwtB5ghI83hTeo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-171-gMqss-F0MWCA1O6CT3YIWg-1; Mon, 13 Sep 2021 11:52:49 -0400 X-MC-Unique: gMqss-F0MWCA1O6CT3YIWg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1BE0C1006AA0; Mon, 13 Sep 2021 15:52:48 +0000 (UTC) Received: from asgard.redhat.com (unknown [10.36.110.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45D8A5C1D1; Mon, 13 Sep 2021 15:52:45 +0000 (UTC) Date: Mon, 13 Sep 2021 17:52:43 +0200 From: Eugene Syromiatnikov To: Jens Axboe Cc: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, "Dmitry V. Levin" , linux-api@vger.kernel.org Subject: Re: [PATCH v2] io-wq: expose IO_WQ_ACCT_* enumeration items to UAPI Message-ID: <20210913155243.GA23359@asgard.redhat.com> References: <20210913104101.GA29616@asgard.redhat.com> <872209f5-d11c-1b80-6146-5646206e22cb@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <872209f5-d11c-1b80-6146-5646206e22cb@kernel.dk> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Mon, Sep 13, 2021 at 07:28:11AM -0600, Jens Axboe wrote: > This is really the same thing as before, just the names have changed. > What I suggested was keeping the enum in io_uring, then just adding > > enum { > IO_WQ_BOUND, > IO_WQ_UNBOUND, > }; > > to uapi header. The ACCT stuff is io-wq specific too, that kind of naming > shouldn't be propagated to userspace. My apologies, I've overlooked the fact that the proposed names are different. Updated and resent[1]. [1] https://lore.kernel.org/lkml/20210913154415.GA12890@asgard.redhat.com/ > A BUILD_BUG_ON() could be added for them being different, but honestly > I don't think that's worth it.