From: Jens Axboe <[email protected]>
To: [email protected], [email protected]
Cc: [email protected], [email protected]
Subject: [PATCHSET v2 0/3] Add ability to save/restore iov_iter state
Date: Tue, 14 Sep 2021 08:17:47 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
Hi,
Linus didn't particularly love the iov_iter->truncated addition and how
it was used, and it was hard to disagree with that. Instead of relying
on tracking ->truncated, add a few pieces of state so we can safely
handle partial or errored read/write attempts (that we want to retry).
Then we can get rid of the iov_iter addition, and at the same time
handle cases that weren't handled correctly before.
I've run this through vectored read/write with io_uring on the commonly
problematic cases (dm and low depth SCSI device) which trigger these
conditions often, and it seems to pass muster.
For a discussion on this topic, see the thread here:
https://lore.kernel.org/linux-fsdevel/CAHk-=wiacKV4Gh-MYjteU0LwNBSGpWrK-Ov25HdqB1ewinrFPg@mail.gmail.com/
You can find these patches here:
https://git.kernel.dk/cgit/linux-block/log/?h=iov_iter.2
Changes since v1:
- Drop 'did_bytes' from iov_iter_restore(). Only two cases in io_uring
used it, and one of them had to be changed with v2. Better to just
make the subsequent iov_iter_advance() explicit at that point.
- Cleanup and sanitize the io_uring side, and ensure it's sane around
worker retries. No more digging into iov_iter_state from io_uring, we
use it just for save/restore purposes.
--
Jens Axboe
next reply other threads:[~2021-09-14 14:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 14:17 Jens Axboe [this message]
2021-09-14 14:17 ` [PATCH 1/3] iov_iter: add helper to save iov_iter state Jens Axboe
2021-09-14 14:17 ` [PATCH 2/3] io_uring: use iov_iter state save/restore helpers Jens Axboe
2021-09-14 18:45 ` Linus Torvalds
2021-09-14 19:37 ` Jens Axboe
2021-09-14 23:02 ` Jens Axboe
2021-09-14 14:17 ` [PATCH 3/3] Revert "iov_iter: track truncated size" Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox