From: Arnd Bergmann <[email protected]>
To: Jens Axboe <[email protected]>, Pavel Begunkov <[email protected]>
Cc: Arnd Bergmann <[email protected]>,
[email protected], [email protected]
Subject: [PATCH] [RFC] io_uring: warning about unused-but-set parameter
Date: Mon, 20 Sep 2021 14:13:44 +0200 [thread overview]
Message-ID: <[email protected]> (raw)
From: Arnd Bergmann <[email protected]>
When enabling -Wunused warnings by building with W=1, I get an
instance of the -Wunused-but-set-parameter warning in the io_uring code:
fs/io_uring.c: In function 'io_queue_async_work':
fs/io_uring.c:1445:61: error: parameter 'locked' set but not used [-Werror=unused-but-set-parameter]
1445 | static void io_queue_async_work(struct io_kiocb *req, bool *locked)
| ~~~~~~^~~~~~
There are very few warnings of this type, so it would be nice to enable
this by default and fix all the existing instances. I was almost
done, but this was added recently as a precaution to prevent code
from using the parameter, which could be done by either removing
the initialization, or by adding a (fake) use of the variable, which
I do here with the cast to void.
Fixes: f237c30a5610 ("io_uring: batch task work locking")
Signed-off-by: Arnd Bergmann <[email protected]>
---
fs/io_uring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 63b0425d6a32..36fbc7f06f5e 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1450,6 +1450,7 @@ static void io_queue_async_work(struct io_kiocb *req, bool *locked)
/* must not take the lock, NULL it as a precaution */
locked = NULL;
+ (void)locked;
BUG_ON(!tctx);
BUG_ON(!tctx->io_wq);
--
2.29.2
next reply other threads:[~2021-09-20 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:13 Arnd Bergmann [this message]
2021-09-20 12:18 ` [PATCH] [RFC] io_uring: warning about unused-but-set parameter Christoph Hellwig
2021-09-20 12:48 ` Arnd Bergmann
2021-09-21 6:54 ` Christoph Hellwig
2021-09-20 23:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox